Commit Graph

230 Commits

Author SHA1 Message Date
Paul Ramos
13449a99b2 Fix #11989. Remove fragment cache, moving to jquery-compat. Close gh-1052. 2012-12-04 21:30:37 -05:00
Paul Ramos
ec72d9f4db Fix #12756. Restyle manipulation unit tests. Close gh-1053.
https://github.com/jquery/2012-dev-summit/issues/56
2012-12-04 20:42:52 -05:00
jaubourg
228ab3ddae Organizes the php scripts used for testing better, so that the whole logic of a unit, server-side and client-side, is contained within the unit itself. Nearly all ajax unit tests take advantage of the new 'framework'. Lots of files got deleted because they became redundant or weren't used anymore. 2012-12-04 07:40:12 +01:00
Richard Gibson
5b9bf13439 No ticket: improve global variable/ajax request tracking 2012-12-02 23:32:16 -05:00
Richard Gibson
b382af685a keep manipulation.js assertions consistent 2012-11-30 16:11:51 -05:00
Oleg
9ae6b1a019 Fix #12957. Simplify wrapMap, it doesn't need end tags. Close gh-1044. 2012-11-27 21:32:59 -05:00
dcooper
78c1560065 Fix #9960, allow manipulation for parent document nodes. Close gh-924. 2012-11-24 16:53:27 -05:00
Dave Methvin
1fb2f92c35 Fix #3827. Get the correct checkbox status for a click handler. 2012-11-24 14:08:51 -05:00
Richard Gibson
bb570fc373 Fix #12920: remove addMandatoryAttributes. Close gh-1037. 2012-11-20 22:57:41 -05:00
Richard Gibson
e889134058 Fix #11795, #10470: keep scripts in DOM; execute only on first insertion. Close gh-864. 2012-11-19 09:50:19 -05:00
Elijah Manor
5904468b9c Fix #8908. Don't let change to originals affect clones in IE9/10. Close gh-886. 2012-11-18 14:49:36 -05:00
Richard Gibson
e78cfb1a37 Fix #12858: don't expose jQuery/Sizzle expandos 2012-11-09 23:43:46 -05:00
Richard Gibson
517846aad2 No ticket: speedup test suite. Close gh-1020. 2012-11-08 10:10:43 -05:00
Timo Tijhof
e2cdf527d6 Followup to gh-997, decode entities in test names. Close gh-1013. 2012-11-01 16:39:45 -04:00
Timo Tijhof
36c9ecb0f5 Implement expectation test instead of using _removeData. Close gh-997.
* Removed inline usage of QUnit.reset() because it is messing with the
  expectation model as reset does .empty() which does a recursive cleanData
  on everything in #qunit-fixture, so any expectJqData above .reset() would
  fail negatively.

  Instead of calling reset inline, either updated the following assertions to
  take previous assertions' state into account, or broke the test() up into
  2 tests at the point where it would call QUnit.reset.

* After introducing the new memory leak discovery a whole bunch of tests were
  failing as they didn't clean up everything. However I didn't (yet) add
  QUnit.expectJqData calls all over the place because in most if not all of
  these cases it is valid data storage. For example in test "data()", there
  will be an internal data key for "parsedAttrs". This particular test isn't
  intending to test for memory leaks, so therefor I made the new discovery
  system only push failures when the test contains at least 1 call to
  QUnit.expectJqData.

  When not, we'll assume that whatever data is being stored is acceptable
  because the relevant elements still exist in the DOM anyway (QUnit.reset
  will remove the elements and clean up the data automatically).

  I did add a "Always check jQuery.data" mode in the test suite that will
  trigger it everywhere. Maybe one day we'll include a call to everywhere,
  but for now I'm keeping the status quo: Only consider data left in storage
  to be a problem if the test says so ("opt-in").

* Had to move #fx-tests inside the fixture because ".remove()" test would
  otherwise remove stuff permanently and cause random other tests to fail
  as "#hide div" would yield an empty collection.
  (Why wasn't this in the fixture in the first place?)

  As a result moving fx-tests into the fixture a whole bunch of tests failed
  that relied on arbitrary stuff about the document-wide or fixture-wide
  state (e.g. number of divs etc.). So I had to adjust various tests to
  limit their sample data to not be so variable and unlimited...

* Moved out tests for expando cleanup into a separate test.

* Fixed implied global variable 'pass' in effects.js that was causing
  "TypeError: boolean is not a function" in *UNRELATED* dimensions.js that
  uses a global variable "pass = function () {};" ...

* Removed spurious calls to _removeData. The new test exposed various failures
  e.g. where div[0] isn't being assigned any data anyway.
  (queue.js and attributes.js toggleClass).

* Removed spurious clean up at the bottom of test() functions that are
  already covered by the teardown (calling QUnit.reset or removeClass to
  supposedly undo any changes).

* Documented the parentheses-less magic line in toggleClass. It appeared that
  it would always keep the current class name if there was any (since the
  assignment started with "this.className || ...".

  Adding parentheses + spacing is 8 bytes (though only 1 in gzip apparently).
  Only added the comment for now, though I prefer clarity with logical
  operators, I'd rather not face the yayMinPD[1] in this test-related commit.

* Updated QUnit urlConfig to the new format (raw string is deprecated).

* Clean up odd htmlentities in test titles, QUnit escapes this.
  (^\s+test\(.*)(&gt\;) → $1>
  (^\s+test\(.*)(&lt\;) → $1<

[1] jQuery MinJsGz Release Police Department (do the same, download less)
2012-10-28 22:44:57 -04:00
Oleg
18e7a53d15 Elements created from html strings have a parentnode. Fixes #12392 2012-10-25 20:41:47 -04:00
Sai Wong
0c1cea3761 Refactored before/after/replaceWith to not pushStack. Fixes #12664, closes gh-987 2012-10-16 16:50:40 -04:00
Daniel Galvez
ef7bce7e5c Fix #11280. IE6-8 need name attribute to parse param. Close gh-914. 2012-10-16 15:07:44 -04:00
Mike Sherov
ed9e34482a enforce double quotes via JSHint. Closes gh-975 2012-10-16 10:17:14 -04:00
James Huston
0c44743496 Enforce expects in manipulation.js (https://github.com/jquery/2012-dev-summit/issues/53) Closes gh-963 2012-10-15 12:19:20 -04:00
Dave Methvin
b6a7d022ee Fix #12347 and #12384. Use a fresh div in jQuery.clean each time.
Regression was introduced in 22ad8723ce most likely because the clown who fixed http://bugs.jquery.com/ticket/4011 didn't add a unit test.
2012-08-28 17:02:01 -04:00
Dave Methvin
a5be986206 Revert "Fix #12120. Always stack .before/.after, and fix disconnected nodes."
This reverts commit e2eac3f4d2.

There is a 1.7 regression with isDisconnected() that we should fix before tackling this.
2012-08-24 11:57:48 -04:00
Dave Methvin
e2eac3f4d2 Fix #12120. Always stack .before/.after, and fix disconnected nodes. 2012-08-23 23:25:57 -04:00
Elijah Manor
10901f7d9f Fix #12266. IE9/10 says document[0] is document.frames[0]? Close gh-903. 2012-08-22 21:48:02 -04:00
Elijah Manor
488e502b98 Improve oldIE unit tests for fuzzy object clone. Close gh-880.
Related to the patch in gh-870.
2012-08-19 20:56:41 -04:00
Elijah Manor
f296335360 Add support check, added assertion to check if cleared, add edge case for backgroundPosition 2012-08-13 07:46:55 -05:00
Elijah Manor
d5d8622329 Fix weird clone bug and add a unit test to verify 2012-08-08 15:31:59 -05:00
Daniel Chatfield
155855b2a9 Fix #12127, fer real. IE9/10 check state on clone. Close gh-875. 2012-07-25 22:23:24 -04:00
Dave Methvin
de213be372 Revert "Fix #12127. IE9/10 checks fall off the box on clone. Close gh-873."
This reverts commit 569d064fc9.

Causing test fails in Safari, IE6, and IE7.
2012-07-25 14:38:55 -04:00
Daniel Chatfield
569d064fc9 Fix #12127. IE9/10 checks fall off the box on clone. Close gh-873. 2012-07-25 09:32:33 -04:00
Dave Methvin
335bdf2b1a Remove a few stray spaces in unit tests. 2012-07-10 21:44:03 -04:00
Uri Gilad
f843a7062f Fix #10517. before() and after() on disconnected node should return multiple nodes. Closes gh-851. 2012-07-10 10:14:43 -04:00
Uri Gilad
21b0db7993 Fix #11962. Standardize getter return values for empty sets. 2012-07-09 23:06:51 -04:00
Chad Killingsworth
de9bed319e Make unit tests friendly to Closure Compiler. Closes gh-845.
Conflicts:
    	test/unit/effects.js
    	test/unit/offset.js
2012-07-05 15:52:42 -04:00
timmywil
b418fa1f09 UPDATE SIZZLE: completed rewrite for better things!
Remove reverse in traversing for comma selectors. Sizzle's handling of commas is now more consistent.
2012-07-02 11:34:26 -04:00
Rick Waldron
7ff3da186c Unit tests are linted and passing. 2012-06-21 15:30:24 -04:00
Sindre Sorhus
ea9ec95276 Fix #11231, (append|prepend|before|after) w/ array of jQuery objects.
Closes gh-666, thanks to @rkatic!
2012-06-15 22:29:02 -04:00
Vladimir Zhuravlev
9c28a320c3 Fix #11566, allow appending to DocumentFragment, closes gh-814. 2012-06-15 21:37:01 -04:00
Dave Methvin
83dfb99ea9 Tweak test for #11743 in an attempt to placate Jenkins.
I can't get the current test to fail locally or in Browserstack, but suspect it may have something to do with badjson.js.
2012-06-11 22:35:04 -04:00
jaubourg
ac48a19b92 Some work to modularize ajax later on. 2012-06-11 14:00:16 +02:00
Mike Sherov
5f35b3d9f9 Fix #11857. Modularize css.js, add dependency management. Closes gh-816.
See the pull request for more info on the dependency management details.
2012-06-10 21:54:16 -04:00
Richard Gibson
742872984e Fix #11743: Don't mask script errors in jQuery.ajax, closes gh-795. 2012-05-31 08:31:13 -07:00
timmywil
a8d9d05388 Add quick-start documentation for testing with QUnit and using jQuery's helper methods. 2012-05-29 13:13:26 -04:00
Oleg
abd2a07498 Fix #8894. Ensure .appendTo creates a new set in oldIE. 2012-04-16 21:57:41 -04:00
Yehuda Katz
6bc08c2b2f Remove Ajax requirement for simple XML tests
Previously, all jQuery tests that wanted an XML
document would make an Ajax request to go through
jQuery's XML parsing logic in jQuery.ajax. Now,
use jQuery.parseXML instead.

This removes the need for the Ajax server for
these tests, improves their performance, and
decouples simple core tests from Ajax.

(with scottgonzalez)
2012-04-15 17:41:54 -04:00
Rick Waldron
5181ce0f35 Amends #10324. Remove object markup fixture; create programmatically 2012-04-11 15:40:03 -04:00
Rick Waldron
62a4c84503 Fix #10324. IE9 fumbles the innerHTML on object elements. 2012-04-10 21:38:11 -04:00
Oleg
c04bfce556 Fixes #11338, .replaceWith should work on detached nodes. 2012-04-05 12:53:36 -04:00
cmcnulty
4cd57d727a Fix 11528. Exclude link/html5 tags from innerHTML path on oldIE. 2012-04-05 12:26:20 -04:00
timmywil
a29d482894 Update Sizzle and add test for sizzle getText fix. Removes usage of innerText. Fixes #11153. 2012-03-30 17:10:25 -04:00
Rick Waldron waldron.rick@gmail.com
379a137016 Failing test (http://gyazo.com/0a7285e1d10039bc8ec8bc340fac15a9.png)
Signed-off-by: Rick Waldron waldron.rick@gmail.com <waldron.rick@gmail.com>
2012-03-23 11:31:05 -04:00
Rick Waldron waldron.rick@gmail.com
619f0d908a Guard against exceptions when clearing safeChildNodes.
Supplements #11356 and fixes unit test failures in FF 3.6.
2012-03-06 12:54:51 -05:00
Sindre Sorhus
92cd999097 Fix #11217. WebKit clone() loses check if name follows checked attribute.
Please folks, hold your questions. We don't explain em, we just fix em.
2012-03-02 13:55:58 -05:00
Rick Waldron waldron.rick@gmail.com
f0732c1e41 Fix #11323. Consistently use rscriptType in jQuery.clean() 2012-03-02 13:13:43 -05:00
Richard Gibson
dec2804c78 Fix #11359: preserve contents for cloned scripts 2012-02-23 23:09:31 -05:00
Rick Waldron waldron.rick@gmail.com
8db3fb13a5 Fix whitespace mismatch introduced in bf7a4df22a 2012-02-10 16:17:12 -05:00
Arne de Bree
bf7a4df22a Fix #11291. Always clone XML docs with a genuine .cloneNode(). 2012-02-09 20:48:21 -05:00
Rick Waldron
499658970b Adds test to support Sizzle getText patch for document fragments. Fixes #10864. 2012-01-20 16:47:49 -05:00
Richard Gibson
6c2a501de4 Fix #5571. Setters should treat undefined as a no-op and be chainable. 2011-12-06 15:25:38 -05:00
Dave Methvin
0de484d483 Use .wrapAll to wrap both text nodes in #10812 so IE9 likey. 2011-11-17 14:15:42 -05:00
Dave Methvin
dd845a2c0f Fix #10812, let .before() and .after() work on empty collections. 2011-11-17 11:47:56 -05:00
timmywil
0cc806fd88 Update Sizzle. Adds document to acceptable nodeTypes for .text(). Fixes #10724. 2011-11-08 15:47:03 -05:00
timmywil
f0e43fad37 Refactor clone a bit to only create one clone on any given codepath 2011-11-08 09:48:57 -05:00
timmywil
41b31d7386 Remove test of the invalid object for IE9's sake; Rewrite the appropriate support test for html5 clone caching. Fixes #10682 2011-11-08 00:05:33 -05:00
Rick Waldron
66e65c8168 Fix busted rnoshimcache. Correctly clone detached unknown elems. Fixes #10667, #10670.
- \s => |, Removes 4 bytes from gzipped build

- Adds tests for clone attributes, children and events
2011-11-07 21:22:04 -05:00
Toby Brain
47c605f693 Fix #10177. Pass correct index to function-parameter of .wrap 2011-11-06 16:59:41 -05:00
Mike Sherov
f35ba5e699 Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit. 2011-11-06 15:27:42 -05:00
Rick Waldron
92c8404012 Fixes jQuery.fragments cache and adds tests. Fixes #10682 2011-11-05 23:06:53 -04:00
timmywil
f3a4d261ec Landing pull request 550. IE6,7,8 cannot use cached fragments from unknown elems. Fixes #10501.
More Details:
- https://github.com/jquery/jquery/pull/550
- http://bugs.jquery.com/ticket/10501
2011-10-23 16:08:10 -04:00
timmywil
3ad0ba62f0 Do not call getElements on a script tag. Avoids unnecessary execution. Fixes #10176. 2011-10-12 00:06:54 -04:00
Dave Methvin
d638aa9c6d Allow more cases to use innerHTML in the .html method.
Thanks @cmcnulty for the pull and the patience!
2011-09-21 23:05:26 -04:00
timmywil
b03648c2a3 Remove stop argument in manipulation test, which no longer sets a timeout 2011-09-20 09:58:20 -04:00
Rick Waldron
9ecdb2472b Landing pull request 490. 1.7 HTML5 Support for innerHTML, clone & style. Fixes #6485.
More Details:
 - https://github.com/jquery/jquery/pull/490
 - http://bugs.jquery.com/ticket/6485
2011-09-19 16:42:36 -04:00
rwldrn
5c3b9e0c24 jQuery.clone() check that destination child nodes are not null. Fixes #9587 2011-06-15 11:14:52 -04:00
timmywil
9d4033d629 Add test for appending an xml element to another. Supplements #9370. 2011-05-25 20:48:59 -04:00
Rick Waldron
ec829431fe Landing pull request 365. jQuery.buildFragment, ensure doc is a document; Fixes #8950.
More Details:
 - https://github.com/jquery/jquery/pull/365
 - http://bugs.jquery.com/ticket/8950
2011-05-13 12:26:17 -04:00
John Resig
f794f48f02 Adding in test case to support #9211. 2011-05-11 11:43:37 -04:00
jaubourg
391398cf23 Fixes #9221. Wraps openings of html comments and CDATA blocks found at the beginning of inserted script elements into a javascript block comment so that the new implementation of globalEval will not throw an exception in IE (execScript being less lenient than eval). Unit tests added. 2011-05-11 14:13:07 +02:00
John Resig
bfad45fe45 Fix problem with appending multiple string arguments in IE 6. Fixes #9072. 2011-05-03 15:02:26 -04:00
Rick Waldron
0c2d1aee54 jQuery.buildFragment, ensure doc is a document; Includes comments; Adds unit test. Fixes #8950 2011-04-30 10:42:36 -04:00
timmywil
d274b7b9f7 Landing pull request 332. Appending disconnected radio or checkbox inputs and keeping checked setting Fixes #8060, #8500.
More Details:
 - https://github.com/jquery/jquery/pull/332
 - http://bugs.jquery.com/ticket/8060
 - http://bugs.jquery.com/ticket/8500
2011-04-21 21:51:23 -04:00
timmywil
ecf6a3c383 Switch QUnit div from depreceted #main to #qunit-fixture 2011-04-17 02:43:57 -04:00
John Resig
3418f32387 Merge branch 'master' of https://github.com/rjgotten/jquery into rjgotten-master. Also added in unit tests covering the case. Fixes #6180.
Conflicts:
	src/manipulation.js
2011-04-12 16:39:30 -04:00
louisremi
f42010b657 third batch 2011-04-12 10:47:46 +02:00
timmywil
de79e8c7e0 Make the new attr/prop changes pass the test suite (in Webkit). There are still errors in IE.
+ Added hooks for selected, checked, readonly, disabled to removeAttr if set to falsey

+ Removed all attrs from attrFix, these aren't needed for setAttribute

+ If prop is used for class, do we want a propFix for class?

  - We could just assume the user should know to use className with prop.  I've done the latter for now.

+ Created tests for $.fn.prop and $.fn.removeProp

  - Actually all I did was change broken attr tests to prop where it made sense.
2011-04-03 19:13:38 -04:00
cmcnulty
2746d7f299 move embed tests to area where objects tests are already happening 2011-03-09 12:44:46 -08:00
Jordan Boesch
dd100bf5ac bug 6158; fixing replaceWith from throwing errors on non existant elements; fixing semicolon 2011-03-05 09:59:25 -06:00
Jordan Boesch
c9ef09c800 bug 6158; fixing replaceWith from throwing errors on non existant elements 2011-03-05 09:46:12 -06:00
cmcnulty
4aafe727da Forgot to update the test counts 2011-02-25 12:26:04 -08:00
cmcnulty
8415e8a13d 2011-02-25 11:45:04 -08:00
jeresig
292acd97a2 Make a new jQuery.support.noCloneChecked - splitting apart the previous feature detect relating to clone in IE, fixes the last remaining issue with IE 9 RC. Fixes #8365. 2011-02-23 13:18:44 -05:00
rwldrn
fa4c90987f Fixes #8129. Fix cloning multiple selected options in IE8. 2011-02-02 00:09:51 +01:00
jeresig
375b787838 The default for .clone() is to not clone any events. Fixes #8123. 2011-02-01 08:57:18 -05:00
Colin Snover
0a0cff9d29 Use the original element/fragment as the last item to be appended to the document instead of the first in order to prevent missing elements when appending to multiple elements. Fixes #8070. 2011-01-28 10:55:39 -06:00
rwldrn
f1bd0cfc4d Merge branch '8017lint' of https://github.com/rwldrn/jquery into 8017lint 2011-01-22 00:41:42 +01:00
rwldrn
33a67ffa9d Basic unit tests; This patch relies on the 51 existing clone() tests 2011-01-21 11:08:15 -05:00
Colin Snover
e78d3a7e2d Merge in data_nocollide branch. Fixes #6968, improves unit testing framework checks for leaky stuff. 2011-01-17 15:31:43 -06:00
Colin Snover
b14f02899e Ensure that buildFragment clones elements properly in all browsers. Fixes #3879, #6655. Also improves form element clone tests and fixes bugs in $.fn.clone exposed by these new test cases related to the values of checkboxes and radio buttons in IE. 2011-01-09 18:38:44 -06:00
Colin Snover
e2941d5a98 Update unit tests with a leak detection mechanism for the various jQuery globals and fix all leaks in the tests. 2011-01-09 15:58:47 -06:00
Dave Methvin
5fd21fc02b Don't cache non-html strings in buildFragment to avoid possible collision with the names of Object methods like toString. Also makes the unit tests 0.5% to 8% faster. Fixes #6779. 2010-12-27 13:43:52 -06:00