dfc693ea25
This is a complete rework of our testing infrastructure. The main goal is to modernize and drop deprecated or undermaintained dependencies (specifically, grunt, karma, and testswarm). We've achieved that by limiting our dependency list to ones that are unlikely to drop support any time soon. The new dependency list includes: - `qunit` (our trusty unit testing library) - `selenium-webdriver` (for spinning up local browsers) - `express` (for starting a test server and adding middleware) - express middleware includes uses of `body-parser` and `raw-body` - `yargs` (for constructing a CLI with pretty help text) - BrowserStack (for running each of our QUnit modules separately in all of our supported browsers) - `browserstack-local` (for opening a local tunnel. This is the same package still currently used in the new Browserstack SDK) - We are not using any other BrowserStack library. The newest BrowserStack SDK does not fit our needs (and isn't open source). Existing libraries, such as `node-browserstack` or `browserstack-runner`, either do not quite fit our needs, are under-maintained and out-of-date, or are not robust enough to meet all of our requirements. We instead call the [BrowserStack REST API](https://github.com/browserstack/api) directly. ## BrowserStack Runner - automatically retries individual modules in case of test failure(s) - automatically attempts to re-establish broken tunnels - automatically refreshes the page in case a test run has stalled - runs all browsers concurrently and uses as many sessions as are available under the BrowserStack plan. It will wait for available sessions if there are none. - supports filtering the available list of browsers by browser name, browser version, device, OS, and OS version (see `npm run test:unit -- --list-browsers` for more info). It will retrieve the latest matching browser available if any of those parameters are not specified. - cleans up after itself (closes the local tunnel, stops the test server, etc.) - Requires `BROWSERSTACK_USERNAME` and `BROWSERSTACK_ACCESS_KEY` environment variables. ## Selenium Runner - supports running any local browser as long as the driver is installed, including support for headless mode in Chrome, FF, and Edge - supports running `basic` tests on the latest [jsdom](https://github.com/jsdom/jsdom#readme), which can be seen in action in this PR (see `test:browserless`) - Node tests will run as before in PRs and all non-dependabot branches, but now includes tests on real Safari in a GH actions macos image instead of playwright-webkit. - can run multiple browsers and multiple modules concurrently Other notes: - Stale dependencies have been removed and all remaining dependencies have been upgraded with a few exceptions: - `sinon`: stopped supporting IE in version 10. But, `sinon` has been updated to 9.x. - `husky`: latest does not support Node 10 and runs on `npm install`. Needed for now until git builds are migrated to GitHub Actions. - `rollup`: latest does not support Node 10. Needed for now until git builds are migrated to GitHub Actions. - BrowserStack tests are set to run on each `main` branch commit - `debug` mode leaves Selenium browsers open whether they pass or fail and leaves browsers with test failures open on BrowserStack. The latter is to avoid leaving open too many sessions. - This PR includes a workflow to dispatch BrowserStack runs on-demand - The Node version used for most workflow tests has been upgraded to 20.x - updated supportjQuery to 3.7.1 Run `npm run test:unit -- --help` for CLI documentation Close gh-5418
8.7 KiB
Contributing to jQuery
Note: This is the code development repository for jQuery Core only. Before opening an issue or making a pull request, be sure you're in the right place.
- jQuery plugin issues should be reported to the author of the plugin.
- jQuery Core API documentation issues can be filed at the API repo.
- Bugs or suggestions for other jQuery organization projects should be filed in their respective repos.
Getting Involved
We're always looking for help identifying bugs, writing and reducing test cases, and improving documentation. And although new features are rare, anything passing our guidelines will be considered.
More information on how to contribute to this and other jQuery organization projects is at contribute.jquery.org, including a short guide with tips, tricks, and ideas on getting started with open source. Please review our commit & pull request guide and style guides for instructions on how to maintain a fork and submit patches.
When opening a pull request, you'll be asked to sign our Contributor License Agreement. Both the Corporate and Individual agreements can be previewed on GitHub.
If you're looking for some good issues to start with, here are some issues labeled "help wanted" or "patch welcome".
Questions and Discussion
Forum and IRC
jQuery is so popular that many developers have knowledge of its capabilities and limitations. Most questions about using jQuery can be answered on popular forums such as Stack Overflow. Please start there when you have questions, even if you think you've found a bug.
The jQuery Core team watches the jQuery Development Forum. If you have longer posts or questions that can't be answered in places such as Stack Overflow, please feel free to post them there. If you think you've found a bug, please file it in the bug tracker. The Core team can be found in the #jquery-dev IRC channel on irc.freenode.net.
Weekly Status Meetings
The jQuery Core team has a weekly meeting to discuss the progress of current work. The meeting is held in the #jquery-meeting IRC channel on irc.freenode.net at Noon EST on Mondays.
How to Report Bugs
Make sure it is a jQuery bug
Most bugs reported to our bug tracker are actually bugs in user code, not in jQuery code. Keep in mind that just because your code throws an error inside of jQuery, this does not mean the bug is a jQuery bug.
Ask for help first in the Using jQuery Forum or another discussion forum like Stack Overflow. You will get much quicker support, and you will help avoid tying up the jQuery team with invalid bug reports.
Disable browser extensions
Make sure you have reproduced the bug with all browser extensions and add-ons disabled, as these can sometimes cause things to break in interesting and unpredictable ways. Try using incognito, stealth or anonymous browsing modes.
Try the latest version of jQuery
Bugs in old versions of jQuery may have already been fixed. In order to avoid reporting known issues, make sure you are always testing against the latest build. We cannot fix bugs in older released files, if a bug has been fixed in a subsequent version of jQuery the site should upgrade.
Simplify the test case
When experiencing a problem, reduce your code to the bare minimum required to reproduce the issue. This makes it much easier to isolate and fix the offending code. Bugs reported without reduced test cases take on average 9001% longer to fix than bugs that are submitted with them, so you really should try to do this if at all possible.
Search for related or duplicate issues
Go to the jQuery Core issue tracker and make sure the problem hasn't already been reported. If not, create a new issue there and include your test case.
Tips For Bug Patching
We love when people contribute back to the project by patching the bugs they find. Since jQuery is used by so many people, we are cautious about the patches we accept and want to be sure they don't have a negative impact on the millions of people using jQuery each day. For that reason it can take a while for any suggested patch to work its way through the review and release process. The reward for you is knowing that the problem you fixed will improve things for millions of sites and billions of visits per day.
Build a Local Copy of jQuery
Create a fork of the jQuery repo on github at https://github.com/jquery/jquery
Clone your jQuery fork to work locally
$ git clone git@github.com:username/jquery.git
Change directory to the newly created dir jquery/
$ cd jquery
Add the jQuery main as a remote. I label mine "upstream"
$ git remote add upstream git://github.com/jquery/jquery.git
Get in the habit of pulling in the "upstream" main to stay up to date as jQuery receives new commits
$ git pull upstream main
Install the necessary dependencies
$ npm install
Build all jQuery files
$ npm run build:all
Start a test server
$ npm run test:server
Now open the jQuery test suite in a browser at http://localhost:3000/test/.
Success! You just built and tested jQuery!
Test Suite Tips...
During the process of writing your patch, you will run the test suite MANY times. You can speed up the process by narrowing the running test suite down to the module you are testing by either double clicking the title of the test or appending it to the url. The following examples assume you're working on a local repo, hosted on your localhost server.
Example:
http://localhost:3000/test/?module=css
This will only run the "css" module tests. This will significantly speed up your development and debugging.
ALWAYS RUN THE FULL SUITE BEFORE COMMITTING AND PUSHING A PATCH!
Change the test server port
The default port for the test server is 3000. You can change the port by setting the PORT environment variable.
$ PORT=3001 npm run test:server
Loading changes on the test page
Rather than rebuilding jQuery with npm run build every time you make a change, you can use the included watch task to rebuild distribution files whenever a file is saved.
$ npm start
Alternatively, you can load tests as ECMAScript modules to avoid the need for rebuilding altogether.
Click "Load as modules" after loading the test page.
Running the test suite from the command line
You can also run the test suite from the command line.
First, prepare the tests:
$ npm run pretest
Make sure jQuery is built (npm run build:all) and run the tests:
$ npm run test:unit
This will run each module in its own browser instance and report the results in the terminal.
View the full help for the test suite for more info on running the tests from the command line:
$ npm run test:unit -- --help
Repo organization
The jQuery source is organized with ECMAScript modules and then compiled into one file at build time.
jQuery also contains some special modules we call "var modules", which are placed in folders named "var". At build time, these small modules are compiled to simple var statements. This makes it easy for us to share variables across modules. Browse the "src" folder for examples.
Browser support
Remember that jQuery supports multiple browsers and their versions; any contributed code must work in all of them. You can refer to the browser support page for the current list of supported browsers.