Oleg
696c553053
Fix failing tests for beforeunload in Safari 5.0. Close gh-1002.
2012-10-21 20:14:05 -04:00
Oleg
9dd0b01017
Fix #12061 . Avoid window.onbeforeunload to permit multiple handlers. Close gh-894.
2012-10-20 22:29:18 -04:00
Allen J Schmidt Jr
c6cf30a56e
Fix #12739 . Keep namespace when triggering with an Event. Close gh-972.
2012-10-19 16:42:13 -04:00
Greg Lavallee
e83bc970f2
Fixes #12736 . Move hover event hack to deprecated.js for removal in 1.9. Closes gh-982.
...
Signed-off-by: Timmy Willison <timmywillisn@gmail.com>
2012-10-16 14:47:11 -04:00
Mike Sherov
ed9e34482a
enforce double quotes via JSHint. Closes gh-975
2012-10-16 10:17:14 -04:00
David Bonner
9104a3d5f2
Deprecate fn toggle Closes gh-970 https://github.com/jquery/2012-dev-summit/issues/24
2012-10-15 17:20:33 -04:00
James Huston
6ac8716789
Enforce expects in events.js ( https://github.com/jquery/2012-dev-summit/issues/53 ) Closes gh-961
2012-10-15 12:16:49 -04:00
Dave Methvin
84e45301c5
Update placeholder references to tickets.
2012-08-28 10:09:22 -04:00
Dave Methvin
afd717df9e
Fix #12383 . All selectors should be delegateTarget-relative
2012-08-28 10:07:16 -04:00
Mike Sherov
a9c2a9bf61
Scorch the earth and retreat on readyState interactive! Close gh-907.
2012-08-23 20:28:22 -04:00
Mike Sherov
0f553ed0ca
Fix #12282 . IE has premature .readyState == "interactive". Close gh-901.
2012-08-20 08:16:07 -04:00
Nikita Govorov
ff7b7cfd1d
Fix #12149 . Avoid memory leak on oldIE change events. Close gh-878.
2012-08-19 20:24:03 -04:00
Dave Methvin
1d8bf0a2b5
Fix #12203 . .undelegate() should not remove direcly bound events.
2012-08-07 20:49:34 -04:00
Timmy Willison
d8aa8e71b0
Sizzle: fix issue with adjusting the context on relative combinators in element-rooted qSA
2012-07-23 14:51:55 -04:00
Richard Gibson
e761e0c6e0
Support event delegation with relative selectors. Fixes #10762 . Closes gh-860.
2012-07-23 12:49:45 -04:00
Richard Gibson
60e249437c
Followup on #10791 : "[class~=foo]" is better. Closes gh-858.
2012-07-12 10:08:24 -04:00
Richard Gibson
d67c2fd863
Wontfix #10791 : please use "[class=foo]" with SVG elements
2012-07-11 17:17:47 -04:00
Mike Sherov
f5fd41252e
Fix #12018 , readyState "interactive" in oldIE lies! Closes gh-848.
2012-07-06 10:12:20 -04:00
Chad Killingsworth
de9bed319e
Make unit tests friendly to Closure Compiler. Closes gh-845.
...
Conflicts:
test/unit/effects.js
test/unit/offset.js
2012-07-05 15:52:42 -04:00
timmywil
b418fa1f09
UPDATE SIZZLE: completed rewrite for better things!
...
Remove reverse in traversing for comma selectors. Sizzle's handling of commas is now more consistent.
2012-07-02 11:34:26 -04:00
Dave Methvin
8a01c9201a
Fix #11382 . #11764 . Only prevent click events on disabled elements.
...
We don't want a disabled link/button to register delegated clicks, but we do want events like mouseover or custom events.
This is a compromise, there is no perfect solution. Well, the browsers could be consistent about direct vs. delegated events but *that's* not gonna happen.
2012-06-27 11:58:16 -04:00
Dave Methvin
94e744aec9
Fix #11315 . Selector for .on() is relative to delegateTarget.
...
This fixes a regresssion from 1.6.4. Be aware that nearly every place that this bug comes into play, the selector in use is incredibly inefficient.
2012-06-27 11:54:04 -04:00
Dave Methvin
4df3aaeab3
Add a semicolon in unit test; this pull predated lint mandate.
2012-06-22 16:21:09 -04:00
Timo Tijhof
9bb3494ce9
Fix #11925 , Pass eventHandle to special.teardown. Closes gh-831.
...
* Added unit test to confirm.
The third assertion fails without the fix in ./src/event.js
2012-06-22 15:57:46 -04:00
Rick Waldron
7ff3da186c
Unit tests are linted and passing.
2012-06-21 15:30:24 -04:00
timmywil
713cc86096
Move quickIs to Sizzle; Remove duplicate id matching in init; Added selector caching to Sizzle. Fixes #11826 .
2012-06-18 23:10:32 -04:00
Mike Sherov
5f35b3d9f9
Fix #11857 . Modularize css.js, add dependency management. Closes gh-816.
...
See the pull request for more info on the dependency management details.
2012-06-10 21:54:16 -04:00
Jason Moon
4757881759
Fix #11796 . Preserve oldIE change delegation on clone. Closes gh-789.
2012-05-22 21:29:13 -04:00
Dave Methvin
978acb9caf
Followup #11649 , clean up events in unit test.
2012-05-18 17:01:17 -04:00
Jason Moon
e93f2a89e2
Fix #11649 . Preserve oldIE submit flag when cloning, closes gh-772.
2012-05-18 16:34:30 -04:00
Dave Methvin
b6581df5de
Fix #11621 , $(document).trigger() must bubble to window.
2012-05-12 14:23:50 -04:00
jaubourg
e3cf0e220c
Transform $.bindReady into $.ready.promise. It is now possible to use $.ready.promise or $.when( $.ready ) to get the ready promise. Costs *1* byte min/gzipped. Unit test added.
2012-05-06 01:05:03 +02:00
Mike Sherov
f925c7a1c9
remove jQuery.quickReady, save bytes, style nits in tests
2012-05-04 10:17:30 -04:00
Mike Sherov
54fab3174c
Fix #10067 . Create jQuery.quickReady; closes gh-736.
...
Allows us to get to the ready state sooner by not waiting for iframes to load. If that causes backcompat pain, use `jQuery.quickReady = false` as prescribed by your developer.
2012-04-23 15:44:27 -04:00
Rick Waldron
8fadc5ba01
Make test async to please Opera 11.1; supplements #11500
2012-04-16 21:42:27 -04:00
Rick Waldron
2f1ddd4507
Fix #11500 . Allow triggered, simulated change events.
2012-04-10 21:54:07 -04:00
Dave Methvin
92a92be10f
Fix #11049 . Let bubbling submit be cancellable in oldIE.
2012-03-06 19:56:17 -05:00
Dave Methvin
633ca9c161
Fix #11076 . If .clone() won't delegate, we must remediate.
...
Since `jQuery.event.add` can accept a handleObj there's no need to reiterate them as args, but we *do* need to set the `selector` variable correctly.
2012-01-28 16:30:35 -05:00
Dave Methvin
8d9025ca50
Fix #8165 : Ignore events bubbling through disabled elements.
...
Although #6911 fixed the case where event.target was disabled, it missed the case where the target was a sub-element.
2012-01-19 22:14:24 -05:00
Rick Waldron
c0da49ff37
Fix #11130 : Don't neglect the data arg when event-map is passed.
2012-01-12 20:30:45 -05:00
Richard Gibson
77de76b942
Fix #11145 : Harden dispatch against a form-aliased "disabled" property
2012-01-11 21:56:18 -05:00
Dave Methvin
4534db196b
Fix #11021 . There should be no mangling of the "hover" namespace.
2011-12-13 22:29:35 -05:00
Dave Methvin
c584ce4f56
Fix #10984 . Use origType when unbinding via the event object.
2011-12-13 21:40:59 -05:00
Dave Methvin
8cb065addc
Fix #10844 . Harden quickIs() against form-aliasing of the id property.
2011-11-21 11:33:21 -05:00
Dave Methvin
780c59b89d
Fix #10791 . SVG clamors for special treatment of its class names.
2011-11-16 10:35:53 -05:00
Dave Methvin
ca8fc725ac
Allow mapped types to be removed by a namespace-only type name.
2011-11-15 11:38:55 -05:00
Dave Methvin
6736dd7168
Fix #10794 . .triggerHandler() should not .preventDefault().
...
This also provides a resolution for #10699 .
2011-11-15 10:23:24 -05:00
Dave Methvin
fa96f4bdee
Pre-focus the element so the browser won't fire focus while we're faking it.
...
At this point the unit test is only testing our ability to fake-fire focusin the right way. These machinations are related to the problem in #6705 .
2011-11-13 21:32:07 -05:00
Dave Methvin
d2815ed750
Disable DOM focusin test since it can't really work in the swarm.
2011-11-13 21:03:36 -05:00
Dave Methvin
683be093a6
Catch more cases where special events were incorrectly removed.
...
We can't take the blow-it-all-away shortcut because something in the middle of the list may be a mapped special event. On the bright side, -22!
2011-11-13 20:50:36 -05:00
Dave Methvin
774eba3388
Avoid collateral damage when removing bindType/delegateType special events.
2011-11-10 21:53:07 -05:00
Dave Methvin
5ba7f60822
Ensure the hover event doesn't match hovercraft. Witchcraft, maybe.
2011-11-10 18:05:58 -05:00
Dave Methvin
dd363d2c0f
Fix #10705 . Don't bail too soon in .off()
event string processing.
2011-11-09 21:29:15 -05:00
Dave Methvin
39f9b846e7
Fix #10712 . Deal with focus/blur morphing to focusin/focusout.
2011-11-08 23:08:04 -05:00
Dave Methvin
45101de696
Fix #10717 , .trigger("load") on images can't bubble to window.
...
This means no manually triggered event named "load" can bubble, so avoid that name for delegated custom events.
2011-11-08 19:32:25 -05:00
Dave Methvin
90c907e8b6
Fix #10701 , .preventDefault if an inline handler returns false.
...
Baby unicorns are slapped each time you use inline handlers, so do it sparingly.
2011-11-07 11:07:36 -05:00
Mike Sherov
f35ba5e699
Fix #10691 . Remove all instances of equals() and same(), as these are deprecated in QUnit.
2011-11-06 15:27:42 -05:00
timmywil
38f087b5ae
Add a way to fire native events using dispatchEvent/fireEvent in testinit.js; fixes failing click test in FF3.6
2011-10-28 14:17:14 -04:00
Dave Methvin
5c0c86378a
DRY the hover pseudo-event, get the type right, allow override.
...
Now with working unit test for extra correctness! If external code defines a special.hover event, we won't string-hack "hover" into "mouseenter mouseleave".
2011-10-27 17:11:40 -04:00
Dave Methvin
df4a160be7
Pass correct arg list to special._default. Thanks @mikaelkaron!
2011-10-27 16:02:54 -04:00
Dave Methvin
746074f0f7
Remove attribute match from quickIs
...
As @timmywil points out, attributes and properties are confused by IE6/7. This commit also reworks the unit test case to do a better job of checking className matches.
2011-10-24 18:05:53 -04:00
Dave Methvin
ee3eb6cabf
Fix #10567 . Make sure quickIs matches correct class name.
2011-10-24 17:26:43 -04:00
Dave Methvin
84d2307e0e
Fix #10563 . Ensure event.currentTarget==this if delegated.
...
Now, event.delegateTarget is always the element where the event was handled, regardless of whether delegated handlers are attached.
2011-10-24 11:18:20 -04:00
Dave Methvin
4ac6f8d9d3
Make jQuery().off(event) work for delegated events.
...
Logic to handle detaching by event was in both .off() and jQuery.event.remove; now it's only in .off(). It's a bit of a strange case since the event object (not the jQuery set) specifies the element.
2011-10-24 11:18:18 -04:00
Dave Methvin
d28ab68699
Make event.currentTarget the delegate node, always.
...
This lets us use currentTarget for its intended use and avoids creating a non-standard delegateTarget property.
2011-10-24 11:18:14 -04:00
Dave Methvin
9fabe2028f
Don't run direct handlers if delegate did .stopPropagation().
2011-10-24 11:18:13 -04:00
Dave Methvin
0a3cab8d49
Fix #10489 . Disconnected elements don't bubble to document.
2011-10-13 16:30:40 -04:00
Dave Methvin
92b06d302c
Tweak live-blur() test to silence a IE8 swarm fail.
2011-10-11 22:55:10 -04:00
Dave Methvin
6afc2c074b
Fixes #10477 . Get .off(type, null, fn)
right.
2011-10-11 20:31:45 -04:00
Dave Methvin
e5b16e3356
Rename jQuery.event.propHooks to .fixHooks.
...
We already have jQuery.propHooks for the .prop() method, so using the same name for unrelated functionality on a sub-namespace is crazy talk. Since the method involved is jQuery.event.fix(), this will hopefully tie them together. Oh, and it's shorter.
2011-10-05 21:41:32 -04:00
Dave Methvin
96a44a86d8
Fix #10375 . Don't put type
in jQuery.event.props
...
It's already set in jQuery.Event, and copying it can clobber values set by the caller, e.g., the UI widget factory.
2011-09-29 10:34:55 -04:00
Rick Waldron
51fd4593fc
Restore original click prop hook
2011-09-26 13:03:24 -04:00
Rick Waldron
d11fcfac18
Fixed tests to run in IE9
2011-09-26 13:00:45 -04:00
Dave Methvin
c7838c3607
Minor cleanups to code. Futile effort to get IE to pass the unit test.
2011-09-25 22:04:52 -04:00
Dave Methvin
b4120a7430
propHooks now an object with props
array and filter
function.
...
Use the originalEvent to grab properties in filter functions since they often won't have been copied to event. Mark a few current props in the main jQuery.event.props list as deprecated, they aren't supported across all browsers.
2011-09-25 19:56:34 -04:00
Dave Methvin
ae27424b30
Merge branch '8789-fun-with-fix' of https://github.com/rwldrn/jquery into fix-8789-rwldrn-fix
...
Conflicts:
src/event.js
test/unit/event.js
2011-09-24 22:37:16 -04:00
Dave Methvin
03d95530b5
Remove the rarely-used pseudos from quickis.html
...
The cutting will continue until file size is improved.
2011-09-21 09:40:57 -04:00
Rick Waldron
92a80cbd05
Adds implementation tests for jQuery.event.propHooks #8789
2011-09-20 12:44:49 -04:00
Dave Methvin
63c9719330
Fix #9901 , verified by this unit test.
2011-09-20 09:17:38 -04:00
Dave Methvin
9aa553aa18
Rework #1486 patch to avoid try/catch
and look for hidden elements by .offsetWidth
. Unit test currently disabled due to Chrome bug.
2011-09-19 15:42:31 -04:00
Dave Methvin
005958b731
Fixes for IE8. Avoid killer recursion in special events during removal. Use q instead of quote in unit tests.
2011-09-19 15:42:31 -04:00
Dave Methvin
6a670df9e9
Rework the special events interface to add handle and trigger hooks. Modify IE change/submit special events to take advantage of them. Rewrite mouseover/enter code as special events rather than inline code. In the event unit test, set a tabindex on the div element and focus it first to justify a legitimate blur event.
2011-09-19 15:42:31 -04:00
Dave Methvin
0dc7b16e94
Fixes #8858 . Pass the .trigger(..., data) to the event.special._default method.
2011-09-19 15:42:31 -04:00
Dave Methvin
d74c6bd0f4
Add unit tests for quickIs cases and fix the regexp as a result.
2011-09-19 15:42:31 -04:00
Dave Methvin
f3a9d30812
Cleanup for on/off unit test.
2011-09-19 15:42:30 -04:00
Dave Methvin
5d6a1424aa
jQuery 1.7 event work:
...
Add .on() and .off() methods.
Write existing methods in terms of on/off.
Rewrite delegated handling to remove "live" event.
Fix existing code for jQuery style guide.
Fix existing bug in unit tests calling .undelegate()
2011-09-19 15:42:30 -04:00
Dave Methvin
8b4bd89add
Fix bad calls to .undelegate().
...
Remove two tests that assume "live" data structure.
2011-09-19 15:42:30 -04:00
Dave Methvin
81c778b2ca
Fix #10208 . Check for button
as well as input
when performing the #7071 VML crash workaround for IE special-events submit code.
2011-09-07 11:30:22 -04:00
Rick Waldron
b5f80a6e31
Removes empty, duplicate named test block. Fixes #9914
2011-07-26 11:49:23 -04:00
rwldrn
6926247bf4
Landing pull request 397. withinElement rewrite in event. Fixes #6234 , #9357 , #9447 .
...
More Details:
- https://github.com/jquery/jquery/pull/397
- http://bugs.jquery.com/ticket/6234
- http://bugs.jquery.com/ticket/9357
- http://bugs.jquery.com/ticket/9447
2011-06-14 15:38:46 -04:00
Rick Waldron
c17f589ec9
Landing pull request 377. Check custom data != null(undefined), allows zero; Fixes #9285 .
...
More Details:
- https://github.com/jquery/jquery/pull/377
- http://bugs.jquery.com/ticket/9285
2011-05-16 10:38:36 -04:00
Rick Waldron
ca367674c1
Restored /g flag to rspaces; Adds unit tests; Supplements #9008
2011-04-28 21:15:45 -04:00
Brian Brennan
3cb9c1835c
Fix live mouseenter and mouseleave binding so they can be activated by triggers. Fixes #6514 .
2011-04-17 18:17:31 -04:00
timmywil
ecf6a3c383
Switch QUnit div from depreceted #main to #qunit-fixture
2011-04-17 02:43:57 -04:00
John Resig
5d70c6d797
Add in unit tests for #6993 .
2011-04-16 17:39:30 -07:00
timmywil
149a040794
Fix test suite fail in IE6/7 on event:undelegate - was failing an if where it shouldn't
2011-04-13 23:14:14 -04:00
Dave Methvin
f7f4ef91cf
Merge branch 'fix_suite_fails' of https://github.com/timmywil/jquery into timmywil-fix_suite_fails
2011-04-12 19:42:35 -04:00
timmywil
69866fd2e5
VML.type test was causing multiple test suite fails, fix attributes.js fail in IE6 where the val(String/Number) tests were interfering with the val(Function) tests
2011-04-12 19:32:18 -04:00
Dave Methvin
bebd8bc01e
Followup to #8753 . Modify new Event constructor signature to jQuery.event(type, props), which can be exploited by jQuery.event.trigger as well.
2011-04-12 19:29:09 -04:00
John Firebaugh
0d8b247cab
Accessing the 'type' property on VML elements fails on IE. Fixes #7071 .
2011-04-12 16:48:22 -04:00