Commit Graph

106 Commits

Author SHA1 Message Date
Oleg Gaidarenko
f1300f1887 Tests: fix another traverse test
Tricky test - if isolated, was executed fine, but falling
if runned with other tests

Ref b97c8d30c5
2016-01-31 12:09:48 +03:00
Oleg Gaidarenko
b97c8d30c5 Tests:Build: update qunit and fix incorrect test
* Update QUnit to the latest version (1.20.0)

* Corrected test was dependent on QUnit UI, which is always a bad idea
2016-01-29 21:22:52 +03:00
Richard Gibson
a268f5225c Traversing: Never let .closest() match positional selectors
Fixes gh-2796
Close gh-2818
2016-01-13 13:37:11 -05:00
Martijn W. van der Lee
0e2f8f9eff Traversing: .not/.filter consistency with non-elements
Fixes gh-2808
Close gh-2809
2016-01-13 13:33:01 -05:00
Timmy Willison
88046440da Selector: pass jQuery unit tests with selector-native
- Ignore certain tests that obviously are not supported
- Beefed up the sortOrder, uniqueSort, isXMLDoc, and attr functions

Fixes gh-1742
Fixes gh-2048
Close gh-2703
2015-11-11 10:10:10 -05:00
Oleg Gaidarenko
c8d15a2f9f Tests: further improvements QUnit 2.0 migration
* Remove QUnit jshint globals
* Extend QUnit.assert methods
* Use assert.async instead of start/stop/done

Ref b930d14ce6
2015-09-08 04:06:20 +03:00
Oleg Gaidarenko
10fdad742a Build: Update jscs and lint files
Fixes gh-2056
2015-09-07 20:03:50 +03:00
Oleg Gaidarenko
b930d14ce6 Tests: partially use new qunit interface
http://qunitjs.com/upgrade-guide-2.x/

For most of the boring work was used
https://github.com/apsdehal/qunit-migrate package

However, it can't update local qunit helpers, plus in some places
old QUnit.asyncTest signature is still used

Fixes gh-2540
2015-08-16 09:02:01 +03:00
Timmy Willison
e1090c3d2b Selector: add jQuery.uniqueSort; deprecate jQuery.unique
Fixes gh-2228
2015-05-04 15:27:12 -07:00
Oleg Gaidarenko
8b6aeae52d Build: fix broken assertions caused by QUnit update
QUnit update broke couple traversing and manipulation tests, since new qunit
added another form to the test-suite while some of
jQuery selectors weren't specific

Ref 2d5c5d213f
2015-02-15 02:22:09 +03:00
Richard Gibson
391c21b15d Traversing: Check all pairwise element combinations for .find( els )
Ref b8d0d54a3c
Fixes #14701
2014-01-17 00:38:56 -05:00
Timo Tijhof
b39ee05b69 traversing: Optimise .add by not using makeArray
Closes gh-1430
2013-12-30 12:34:08 -05:00
Richard Gibson
9c4a428528 Fix #13846: .prev sort direction 2013-05-01 11:33:06 -04:00
Richard Gibson
78c803f1b5 Fix #13819: .parent sort direction
(cherry picked from commit 6a816ec95f)
2013-04-24 11:40:42 -04:00
Richard Gibson
fb1731ab16 Fix #13797: .is with single-node context
(cherry picked from commit 4f786ba4d2)
2013-04-20 11:51:51 -04:00
Timmy Willison
0fa52c11cb Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755. 2013-04-09 11:59:31 -04:00
Michał Gołębiowski
52394ba986 Move size() test to deprecated.js and avoid in other tests. Close gh-1237. 2013-04-08 20:38:20 -04:00
Richard Gibson
5d1dfe7474 Fix #13539: Utilize Sizzle hooks. Close gh-1215.
(cherry picked from commit 4ef516903e)
2013-04-05 00:37:36 -04:00
dmitrygusev
eee2eaf1d7 Fix typos. Close gh-1186. 2013-02-28 15:45:10 -05:00
Nguyen Phuc Lam
8bc7bdebef Ref #13283, move .andSelf() to deprecated.js. Close gh-1170. 2013-02-26 22:57:12 -05:00
Richard Gibson
59f5adb622 No ticket: Revise unit tests in anticipation of Sizzle-free builds 2013-02-22 20:13:36 -05:00
Richard Gibson
b734666f4d Fix #13265 #13332: traversing methods with text nodes. Close gh-1145. 2013-02-13 22:03:37 -05:00
Oleg
65bdfbf07f Reduce traversing module 2012-12-19 19:42:33 +04:00
Richard Gibson
a763ae7277 Fix #11115: Normalize boolean attributes/properties. Close gh-1066. 2012-12-15 23:16:48 -05:00
timmywil
05531fc408 Adjust jQuery('html') detection to only match when html starts with '<' (not counting space characters). Fixes #11290. 2012-12-13 15:31:02 -05:00
Timo Tijhof
55313d32a2 Test: Update index.html to new QUnit format. Close gh-1061.
Depends on jquery/sizzle#177, included with the Sizzle submodule in this commit.
2012-12-10 21:48:20 -05:00
Dave Methvin
8657538b33 Test case for #12816 2012-10-31 23:36:43 -04:00
Mike Sherov
e8f91514a6 Fix #12009. $().find( DOMElement ) should pushStack properly. Close gh-927. 2012-10-30 13:32:53 -04:00
Timo Tijhof
36c9ecb0f5 Implement expectation test instead of using _removeData. Close gh-997.
* Removed inline usage of QUnit.reset() because it is messing with the
  expectation model as reset does .empty() which does a recursive cleanData
  on everything in #qunit-fixture, so any expectJqData above .reset() would
  fail negatively.

  Instead of calling reset inline, either updated the following assertions to
  take previous assertions' state into account, or broke the test() up into
  2 tests at the point where it would call QUnit.reset.

* After introducing the new memory leak discovery a whole bunch of tests were
  failing as they didn't clean up everything. However I didn't (yet) add
  QUnit.expectJqData calls all over the place because in most if not all of
  these cases it is valid data storage. For example in test "data()", there
  will be an internal data key for "parsedAttrs". This particular test isn't
  intending to test for memory leaks, so therefor I made the new discovery
  system only push failures when the test contains at least 1 call to
  QUnit.expectJqData.

  When not, we'll assume that whatever data is being stored is acceptable
  because the relevant elements still exist in the DOM anyway (QUnit.reset
  will remove the elements and clean up the data automatically).

  I did add a "Always check jQuery.data" mode in the test suite that will
  trigger it everywhere. Maybe one day we'll include a call to everywhere,
  but for now I'm keeping the status quo: Only consider data left in storage
  to be a problem if the test says so ("opt-in").

* Had to move #fx-tests inside the fixture because ".remove()" test would
  otherwise remove stuff permanently and cause random other tests to fail
  as "#hide div" would yield an empty collection.
  (Why wasn't this in the fixture in the first place?)

  As a result moving fx-tests into the fixture a whole bunch of tests failed
  that relied on arbitrary stuff about the document-wide or fixture-wide
  state (e.g. number of divs etc.). So I had to adjust various tests to
  limit their sample data to not be so variable and unlimited...

* Moved out tests for expando cleanup into a separate test.

* Fixed implied global variable 'pass' in effects.js that was causing
  "TypeError: boolean is not a function" in *UNRELATED* dimensions.js that
  uses a global variable "pass = function () {};" ...

* Removed spurious calls to _removeData. The new test exposed various failures
  e.g. where div[0] isn't being assigned any data anyway.
  (queue.js and attributes.js toggleClass).

* Removed spurious clean up at the bottom of test() functions that are
  already covered by the teardown (calling QUnit.reset or removeClass to
  supposedly undo any changes).

* Documented the parentheses-less magic line in toggleClass. It appeared that
  it would always keep the current class name if there was any (since the
  assignment started with "this.className || ...".

  Adding parentheses + spacing is 8 bytes (though only 1 in gzip apparently).
  Only added the comment for now, though I prefer clarity with logical
  operators, I'd rather not face the yayMinPD[1] in this test-related commit.

* Updated QUnit urlConfig to the new format (raw string is deprecated).

* Clean up odd htmlentities in test titles, QUnit escapes this.
  (^\s+test\(.*)(&gt\;) → $1>
  (^\s+test\(.*)(&lt\;) → $1<

[1] jQuery MinJsGz Release Police Department (do the same, download less)
2012-10-28 22:44:57 -04:00
Timmy Willison
420dcc5842 Update Sizzle: allows disconnected sorting. Change add to always sort with added nodes, even when disconnected. 2012-10-16 11:54:54 -04:00
MORGAN
4bb46f413a Return correct index for no-arg index() calls. Fixes #10977. Closes gh-971 2012-10-16 10:25:08 -04:00
Mike Sherov
ed9e34482a enforce double quotes via JSHint. Closes gh-975 2012-10-16 10:17:14 -04:00
James Huston
435fbe1793 Enforce expects in events.js (https://github.com/jquery/2012-dev-summit/issues/53) Closes gh-962 2012-10-15 12:18:14 -04:00
Timmy Willison
e07b444dfe Fix a regression where has with multiple contexts was not filtering correctly. Test added. 2012-07-27 18:19:18 -04:00
Timmy Willison
17a26f5bd9 Fail silently if closest is somehow called on a document. Fixes #10726. 2012-07-25 16:05:59 -04:00
Dave Methvin
cde4c326b8 Fix #11969. Never a null moment when checking siblings. 2012-06-26 17:08:49 -04:00
Rick Waldron
7ff3da186c Unit tests are linted and passing. 2012-06-21 15:30:24 -04:00
Ben Alman
02dd7c570b jQuery#addBack supports an optional selector that can be used to filter the prior set before adding it back. Fixes #9800 2012-05-29 12:04:27 -04:00
Dave Methvin
f76518e393 Rename .andSelf to .addBack, deprecate .andSelf #9800 2012-05-15 23:14:13 -04:00
Dave Methvin
56d5c1c3a3 Fix #11738. Remove deprecated .closest(Array) => Array. 2012-05-11 15:11:13 -04:00
Richard Gibson
590bcab245 Fix #11543: .has should work on detached elements. 2012-04-05 21:03:41 -04:00
Richard Gibson
a619cb3063 Fix #11370: .siblings() shouldn't throw exception on a detached element 2012-02-23 22:40:07 -05:00
timmywil
2a63b980ed Use Sizzle.Expr.match.globalPOS for identifying POS selectors in traversing. Fixes #10970. 2011-12-12 11:23:47 -05:00
Rick Waldron
7cbd7a640f Coerce eq() argument all the time. Fixes #10616 2011-11-06 16:17:59 -05:00
Mike Sherov
f35ba5e699 Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit. 2011-11-06 15:27:42 -05:00
Dave Methvin
70e2e32e0e Landing pull request 491. Fix #7322. Make .is() with a positional selector work like delegated event logic. Fixes #7322.
More Details:
 - https://github.com/jquery/jquery/pull/491
 - http://bugs.jquery.com/ticket/7322
2011-09-19 23:50:52 -04:00
timmywil
0ced30e319 Move filter tests to proper location 2011-09-19 23:14:37 -04:00
timmywil
11c9de477c Added filtering tests and updating sizzle to fix filtering with positional selectors. Fixes #10315. 2011-09-19 23:09:40 -04:00
timmywil
92405d4f5f Override Sizzle attribute retrieval with jQuery.attr. Fixes #5637, #7128, #9261, #9570, #10178.
Bug fixed on the side: $(window).is('a') was throwing an exception. Fixes #10178.
2011-09-19 15:42:30 -04:00
Rick Waldron
13647e94e0 Fixes assertion counts and dom element fixture issue 2011-08-05 10:02:33 -04:00