Timmy Willison
3bbcce68d7
Core: rnotwhite -> rhtmlnotwhite and jQuery.trim -> stripAndCollapse
...
- Renames and changes rnotwhite to focus on HTML whitespace chars
- Change internal use of jQuery.trim to more accurate strip and collapse
- Adds tests to ensure HTML space characters are retained where valid
- Doesn't add tests where the difference is inconsequential and
existing tests are adequate.
Fixes gh-3003
Fixes gh-3072
Close gh-3316
2016-09-15 10:40:27 -04:00
Oleg Gaidarenko
58c6ca9822
Build: ESLint details
...
Use eslint pragmas, fix new errors, etc
Closes gh-3148
2016-06-11 10:41:33 +03:00
Michał Gołębiowski
e06fda69f0
Attributes: Avoid infinite recursion on non-lowercase attribute getters
...
Attribute hooks are determined for the lowercase versions of attribute names
but this has not been reflected in the bool attribute hooks. The code that
temporarily removed a handler to avoid an infinite loop was removing an
incorrect handler causing stack overflow.
Fixes gh-3133
Refs gh-2914
Refs gh-2916
Closes gh-3134
2016-06-03 22:48:43 +02:00
Michał Gołębiowski
f9ea869ab5
Tests: Remove side-effects of one attributes test
...
One test in the attribute module was overwriting jQuery.expr.attrHandle.checked
and wasn't restoring the original state after it finished. It started causing
issues for another checked-related test.
2016-06-03 11:51:33 +02:00
Timmy Willison
7052698191
Attributes: strip/collapse whitespace for set values on selects
...
Fixes gh-2978
Close gh-3002
2016-03-17 12:24:51 -04:00
Alexander Lisianoi
ddb2c06f51
Tests: limit selection to #qunit-fixture in attributes.js
...
Ref gh-2880
Close gh-2921
2016-02-22 11:56:04 -05:00
William Robinet
12038c7234
Tests: fix typos
...
Closes gh-2927
2016-02-17 14:13:45 -05:00
Timmy Willison
780cac802b
Attributes: fix setting selected on an option in IE<=11
...
Fixes gh-2732
Close gh-2840
2016-01-19 11:36:47 -05:00
Timmy Willison
a4d16a26ab
Revert "Attributes: Remove undocumented .toggleClass( boolean ) signature"
...
This reverts commit 53f798cf4d
.
- Turns out this is documented, even if not fully. Need to deprecate before removal.
2016-01-07 14:06:41 -05:00
Timmy Willison
fbf829b724
Attributes: exclusively lowercase A-Z in attribute names
...
Fixes gh-2730
Close gh-2749
2015-12-02 10:39:02 -05:00
Timmy Willison
79fc806e85
Attributes: return empty array for select-multiple with no values
...
Fixes gh-2562
Close gh-2689
2015-11-05 17:41:49 -05:00
Timmy Willison
87bd130289
Attributes: remove flakey test for selected attribute
...
- The change is already covered by the "checked" test.
Since this test is redundant, just drop it.
2015-10-26 11:38:04 -04:00
Richard Gibson
f931786018
Tests: Post-Summit cleanup
...
Ref 67d7a2eefe
Ref c752a5030b
2015-10-25 15:25:56 -04:00
Timmy Willison
47ccf3daad
Attributes: do not set properties to false when removing booleans
...
Fixes gh-1759
2015-10-21 16:23:44 -04:00
Joelle Fleurantin
c752a5030b
Attributes: fix tabIndex on <img> in IE11
...
Fixes gh-2647
Closes gh-2664
2015-10-18 16:36:52 -04:00
Dave Methvin
4bf1a09522
Attributes: Use simpler boolean check vs a function call
...
Ref gh-2491
2015-10-18 12:39:38 -04:00
Dave Methvin
53f798cf4d
Attributes: Remove undocumented .toggleClass( boolean ) signature
...
Fixes gh-2491
Close gh-2618
2015-10-18 12:38:59 -04:00
Oleg Gaidarenko
c8d15a2f9f
Tests: further improvements QUnit 2.0 migration
...
* Remove QUnit jshint globals
* Extend QUnit.assert methods
* Use assert.async instead of start/stop/done
Ref b930d14ce6
2015-09-08 04:06:20 +03:00
Oleg Gaidarenko
10fdad742a
Build: Update jscs and lint files
...
Fixes gh-2056
2015-09-07 20:03:50 +03:00
Oleg Gaidarenko
b930d14ce6
Tests: partially use new qunit interface
...
http://qunitjs.com/upgrade-guide-2.x/
For most of the boring work was used
https://github.com/apsdehal/qunit-migrate package
However, it can't update local qunit helpers, plus in some places
old QUnit.asyncTest signature is still used
Fixes gh-2540
2015-08-16 09:02:01 +03:00
Oleg Gaidarenko
aabe94edb4
Tests: don't use deprecated argument in test declaration
...
Closes gh-2507
2015-07-30 20:46:31 +03:00
Timmy Willison
20aaed367f
Attributes: add SVG class manipulation
...
- Note: support for SVG is limited in jQuery,
but this is one area where the cost vs benefit ratio
was acceptable.
Fixes gh-2199
Close gh-2268
2015-05-12 10:13:46 -04:00
Timmy Willison
2905961bf7
Attributes: revert returning null for non-existant attributes
...
Ref https://github.com/jquery/jquery/issues/2118
2015-03-30 15:32:54 -04:00
Timmy Willison
7632b7454b
Attributes: revert returning null for non-elements
2015-03-16 14:11:38 -04:00
Timmy Willison
5dc4616ca0
Attributes: fix failing test for new return value
2015-03-16 11:52:05 -04:00
Winston Howes
aaeed53e9f
Attributes: return null when attribute does not exist
...
Fixes gh-2118
Close gh-2129
2015-03-16 11:21:24 -04:00
Michał Gołębiowski
f6302b0b53
Attributes: Use the option val hook in select val hook and simplify it
...
The hook is still defined; not using it could cause issues in IE<11.
Also, IE10 no longer throws when value not set but it still doesn't trim the
value. IE11 has all those issues fixed; support comments are updated.
Fixes gh-1902
Closes gh-1901
2014-12-08 22:39:58 +01:00
Richard Gibson
26276a307c
Tests: Minor updates for QUnit 1.16 compatibility
...
More to come later.
(cherry picked from commit f6f8848fbe
)
2014-12-05 12:34:17 -05:00
Oleg Gaidarenko
ebbbe965b8
Tests: Correct logic of a broken assertion
2014-04-15 17:45:59 +04:00
John Hoven
541e7349b6
Attributes: Trim whitespace from option text when returned as a value
...
Fixes #14858
Ref #14686
Closes gh-1531
(cherry picked from commit 9ec429cf62
)
Conflicts:
src/attributes/val.js
2014-03-20 15:47:35 -04:00
Oleg
a2250b0f4c
Tests: Fix code style issues
2014-01-16 07:04:14 +04:00
Oleg
659ac9c155
Tests: Add assertion for the jQuery#val method
2014-01-16 06:58:54 +04:00
Oleg
fdd78fad19
Attrs: Remove outdated valHook for option element
...
This hook was relevant for BlackBerry 4.7 which is no longer supported.
But this code path now raises error in IE10-11 (#14686 ) in 1.x-master branch.
So to just to be safe, also add test for IE issue to this branch too.
2014-01-16 04:47:44 +04:00
cjqed
537e9ced61
Tests: Avoid use of QUnit.reset() in tests by splitting them
...
Fix #14040
Close gh-1457
2013-12-23 17:21:22 -05:00
Michał Gołębiowski
4b39a82890
Fix #14340 . Remove remnants of oldIE from unit tests. Close gh-1425.
2013-11-11 00:43:27 +01:00
Michał Gołębiowski
35b2b94979
Add tests for class manipulation on jQuery object containing more than one element. Close gh-1404.
2013-10-25 00:48:54 +02:00
Richard Gibson
0c18520923
No ticket: Hide the testing-support jQuery from tests
2013-09-03 10:43:32 -04:00
Timmy Willison
01d5a1a1c9
Fix for custom attr handles duck-punching the boolean attr handle
...
Conflicts:
src/attributes/attr.js
2013-08-28 12:23:54 -04:00
Richard Gibson
d8a35011ec
Fix #13835 : classes separated by form feed
2013-05-13 21:55:00 -04:00
Timmy Willison
0fa52c11cb
Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755 .
2013-04-09 11:59:31 -04:00
Oleg Gaidarenko
f1ba486ee3
Adjust tabIndex propHook for modern browsers and return -1 where appropriate. Close gh-1228.
2013-04-08 21:33:17 -04:00
Michał Gołębiowski
52394ba986
Move size() test to deprecated.js and avoid in other tests. Close gh-1237.
2013-04-08 20:38:20 -04:00
Michał Gołębiowski
1205103a72
Update grunt-contrib-jshint to 0.3.0, close gh-1204.
...
(cherry picked from 4adde5d145
)
Conflicts:
src/data.js
src/effects.js
2013-04-03 20:51:30 -04:00
ruado1987
c9ca9bf509
Fix #13514 : Set selectedIndex to -1 when non-matching value is set on a select. Close gh-1191.
...
(cherry picked from commit 48d71d0c3e
)
2013-03-22 12:47:01 -04:00
Michał Z. Gołębiowski
79992d7523
Edited comments and minor adjustments. Fixes #13553 . Closes gh-1195.
2013-03-12 21:06:25 -04:00
dmitrygusev
eee2eaf1d7
Fix typos. Close gh-1186.
2013-02-28 15:45:10 -05:00
Richard Gibson
59f5adb622
No ticket: Revise unit tests in anticipation of Sizzle-free builds
2013-02-22 20:13:36 -05:00
Dave Methvin
6f7b6915bf
Fix #12656 . Make event shorthands excludable.
2013-01-27 09:07:00 -05:00
Timmy Willison
d96fa37666
2.0: Remove style->cssText attroproties fallback
2012-12-31 13:21:47 -05:00
Mike Sherov
abead1c86b
Fixes #13088 : under IE8, $(selector).attr('style') always return lowercase string
2012-12-31 12:30:02 -05:00