Oleg
3c1b42805d
Take care of comments
2012-12-24 03:04:19 +04:00
Oleg
ec75705f88
Remove needless expression
2012-12-24 03:04:19 +04:00
Oleg
0d16158f69
Revert changes in support module
2012-12-24 03:04:18 +04:00
Oleg
3eb1f64966
Use GET method in jQuery#domManip
2012-12-24 03:04:18 +04:00
Oleg
a8b38b0e6b
Remove couple of spaces
2012-12-24 03:04:18 +04:00
Oleg
8958f7cd9d
More simplifications fore jQuery#html
2012-12-24 03:04:18 +04:00
Oleg
bc70e0c718
Speed up iteration in jQuery#domManip if it called with function inside first argument
2012-12-24 03:04:18 +04:00
Oleg
f07e6758ae
Simplify execution of script element if it processed without src attribute
2012-12-24 03:04:08 +04:00
Oleg
d086aa16b3
Use jQuery.merge only if it really necessary
2012-12-24 03:04:08 +04:00
Oleg
d552b94463
Simplify jQuery.expando
2012-12-24 03:04:08 +04:00
Oleg
c334878871
Simplify wrapMap
2012-12-24 03:04:08 +04:00
Oleg
1043fa8971
Move all helpers to the end of the module
2012-12-24 03:04:08 +04:00
Oleg
a10dd521df
Remove fixDefaultChecked helper
2012-12-24 03:03:28 +04:00
Oleg
61d01c8d35
Simplify getAll helper
2012-12-24 03:03:28 +04:00
Oleg
7a5000a39e
Simplify fixCloneNodeIssues helper
2012-12-24 03:03:28 +04:00
Oleg
329d5e1d03
Remove memory fix
2012-12-24 03:03:28 +04:00
Oleg
e9ea6679b2
Change "isFunc" variable to "isFunction"
2012-12-24 03:03:28 +04:00
Oleg
76bde01be8
Code style changes
2012-12-24 03:03:28 +04:00
Oleg
8c4b9f082b
Simplify jQuery#wrap
2012-12-24 03:03:28 +04:00
Oleg
2378438a97
Code style changes
2012-12-24 03:03:27 +04:00
Oleg
28f6fcb763
Remove unused variables
2012-12-24 03:03:19 +04:00
Oleg
eac4e8e251
Remove removal of container children through removeChild method
2012-12-24 03:03:19 +04:00
Oleg
7a2a82ba62
Remove tbody check
2012-12-24 03:03:19 +04:00
Oleg
c1c97b474e
Remove leading white space check
2012-12-24 03:03:19 +04:00
Oleg
fd2af63bca
Remove createSafeFragment helper
2012-12-24 03:03:19 +04:00
Dave Methvin
861a45b8ff
Followup to gh-1089. Avoid duplicate typeof check.
2012-12-23 15:57:01 -05:00
Sebi Burkhard
5eec75e582
Fix #13075 . Optimize $.type by preferring typeof
. Close gh-1089.
...
Also fixes browsers where `typeof RegExp === "function"`.
2012-12-23 15:41:56 -05:00
Sebi Burkhard
d829804631
Fix #13076 . Speed up $() with strings, part of gh-1089.
2012-12-23 15:09:10 -05:00
Richard Gibson
3e1589db32
Update Sizzle
2012-12-21 15:51:37 -05:00
Richard Gibson
1e7e541b8b
Fix 00bbbe20
test failures
2012-12-21 10:34:03 -05:00
Oleg
c8c6ab6924
Fix #12569 . Improve feature detect for event bubbling. Close gh-1076.
2012-12-20 22:08:32 -05:00
Richard Gibson
00bbbe2075
Fix #13070 : better unescaping logic in Sizzle
2012-12-20 21:56:53 -05:00
Oleg
5afc93c436
Fix #13094 . Pass index to .before(fn) fn as documented. Close gh-1093.
2012-12-20 20:55:30 -05:00
Oleg
38941579fc
Code style
2012-12-19 19:42:33 +04:00
Oleg
65bdfbf07f
Reduce traversing module
2012-12-19 19:42:33 +04:00
Dave Methvin
1e0eca0f77
2.0: Reduce css.js
2012-12-18 22:21:32 -05:00
Dave Methvin
eed78cc321
Fix #13078 . Remove .live() and .die(). Great rejoicing.
2012-12-18 13:24:05 -05:00
Timmy Willison
963c47f9ed
Sizzle: :lang updates for handling backslashes, xml, and inheritance
2012-12-18 11:50:54 -05:00
Timmy Willison
5c8984efc4
Sizzle: QA for :lang from gibson
2012-12-17 15:13:09 -05:00
Timmy Willison
d6d6c3efe7
Sizzle: add support for :lang selector
2012-12-17 12:10:22 -05:00
Richard Gibson
06f46dad93
let .attr(checked|selected, true) update the property
2012-12-16 10:39:19 -05:00
Richard Gibson
a763ae7277
Fix #11115 : Normalize boolean attributes/properties. Close gh-1066.
2012-12-15 23:16:48 -05:00
Timmy Willison
55a8ba5226
Sizzle: size optimization
2012-12-15 13:05:58 -05:00
Timmy Willison
54cbcf1f3d
Sizzle: initialize with default document on load to get it out of the way for most use cases
2012-12-15 12:50:30 -05:00
Timmy Willison
d907848642
Sizzle: assume window.document in Sizzle.matches; massively reduce calls to setDocument by not calling when context is null
2012-12-15 10:50:35 -05:00
Timmy Willison
cc164a36f4
Update Sizzle
2012-12-15 10:33:33 -05:00
Timmy Willison
8424933153
Update Sizzle: avoid calling setDocument when possible
2012-12-15 10:26:24 -05:00
Richard Gibson
60fdc12b96
Update Sizzle
2012-12-15 01:26:18 -05:00
Timmy Willison
73689060ef
Update Sizzle: IE6-8 traversing test fix
2012-12-14 19:06:31 -05:00
Timmy Willison
8b4cdbb663
Sizzle: fix test failures related to Sizzle.contains
2012-12-14 19:00:41 -05:00
Timmy Willison
04bcb173a0
Sizzle: :target and :root selector support. adds Sizzle.setDocument. Remove :active support.
2012-12-14 17:24:39 -05:00
Richard Gibson
2c40fdd4a8
Fix #12600 : don't use value property in place of value attribute. Close gh-1063.
2012-12-14 10:37:20 -05:00
timmywil
05531fc408
Adjust jQuery('html') detection to only match when html starts with '<' (not counting space characters). Fixes #11290 .
2012-12-13 15:31:02 -05:00
Richard Gibson
452e32769d
compress -16 min+gzip
2012-12-13 12:41:25 -05:00
Oleg
643ecf9d63
Ref #8908 , gh-886. Avoid clone identity crisis in IE9/10. Close gh-1036.
2012-12-13 10:42:43 -05:00
Scott González
a270d638f8
CSS: Save some bytes. Close gh-1071.
2012-12-13 10:06:06 -05:00
Oleg
13651f296d
Fix #9646 . Cloned nodes shouldn't affect original in IE7. Close gh-947.
2012-12-13 09:29:40 -05:00
Dave Methvin
0018f7700b
Fix #11230 . .appendTo and pals should always stack.
2012-12-13 09:19:41 -05:00
Paul Ramos
f12611feb4
Fix #4087 . insertAfter, insertBefore, etc do not work if origin and destination are same element. Close gh-1068.
2012-12-11 23:35:22 -05:00
Dave Methvin
aad235b325
Fix #13011 . Let 'type' attribute be set if the browser allows.
2012-12-11 23:16:08 -05:00
Richard Gibson
1d1c80d377
copy defaultSelected in cloneFixAttributes
2012-12-11 23:05:18 -05:00
Bennett Sorbo
32842ac365
Fix #12990 . Don't add 'px' to column-count. Close gh-1050.
2012-12-11 22:38:37 -05:00
Oleg
93e18922c5
Fix #12956 . Improve cloneFixAttributes for IE9/10 case. Close gh-1034.
...
Remove clear(merge)Attributes hack
2012-12-11 22:06:26 -05:00
Mike Sherov
ef6d8779de
Fixes #11938 : Adding array getter method to jQuery.fn.css
2012-12-11 13:58:14 -05:00
Mike Sherov
a918dc8aac
Pass style declarations around for performance improvements and paving the way for the css array signature
...
Also, simplify the jQuery.css numeric coercion signature
2012-12-11 13:58:14 -05:00
Richard Gibson
aa0e4aadd5
Update Sizzle
2012-12-11 09:25:37 -05:00
Timo Tijhof
55313d32a2
Test: Update index.html to new QUnit format. Close gh-1061.
...
Depends on jquery/sizzle#177 , included with the Sizzle submodule in this commit.
2012-12-10 21:48:20 -05:00
Oleg
d41b983259
Fix #10417 . setTimeout w/o 2nd arg is jQuery.later! Close gh-1065.
2012-12-10 20:51:49 -05:00
Rick Waldron
3c7f2af81d
Be specific about Firefox nodes-as-nodelist. Never assume that modern browsers will "get it right".
...
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2012-12-10 20:19:26 -05:00
Rick Waldron
07a7b3e4cf
Fixes #13021 . Normalization of core utility array like detection based on standard protocol by Richard Gibson <richard.gibson@gmail.com>. Closes gh-1064
2012-12-10 13:52:02 -05:00
Rick Waldron
7d5b86ec39
Refactor defaultDisplay's node creation and display logic, -6
2012-12-10 10:05:39 -05:00
Dave Methvin
2eda329be6
Ref #13019 and gh-1062. Use parentNode check instead of isDisconnected().
2012-12-09 14:46:06 -05:00
Dave Methvin
f8f52cfcf4
Fix #13019 . Disconnected nodes with .replaceWith are a noop. Close gh-1062.
2012-12-09 14:10:38 -05:00
Richard Gibson
d343e6b9ed
Fix #12904 : Firefox defaultDisplay with body/iframe display:none. Report and solution by @maranomynet; test by @rwldrn.
2012-12-08 18:04:13 -05:00
jaubourg
23d7cf0488
Deferred: .resolve(), .reject() and .notify() now set the callback context to the promise instance rather than the deferred instance ; .then() has also been amended. Fixes #11405 .
2012-12-07 15:14:12 +01:00
Dave Methvin
282c044d64
Fix #13013 . Move jQuery.buildFragment() to compat plugin.
2012-12-06 21:17:27 -05:00
Timo Tijhof
5dd8a90f73
Make compatible with jshint, lint test/data. Close gh-1043.
2012-12-06 13:46:37 -05:00
Richard Gibson
26bf8dd56b
once more with feeling
2012-12-05 23:47:33 -05:00
Richard Gibson
9bfe9e7dfb
don't test SVG on IE6
2012-12-05 23:30:53 -05:00
Richard Gibson
abe009cf26
Fix #10832 (this time with tests): jQuery.contains in SVG
2012-12-05 22:42:54 -05:00
Rod Vagg
551c2c9f4a
Fixes #12449 . make replaceWith() clone elements where required. Closes gh-920
2012-12-04 21:50:22 -05:00
Paul Ramos
13449a99b2
Fix #11989 . Remove fragment cache, moving to jquery-compat. Close gh-1052.
2012-12-04 21:30:37 -05:00
Richard Gibson
3ab26340dc
Fix #12856 : keep PSEUDO regex non-greedy
2012-12-03 23:43:34 -05:00
Dave Methvin
c2d6847de0
Fix #12989 . Remove ajax "global" event behavior.
2012-12-01 20:29:32 -05:00
jaubourg
e63625e16e
Fixes awkward spacing
2012-11-29 17:28:16 +01:00
jaubourg
8a79be7894
Simplifies how url is kept devoid of anti-cache parameter for ifModified requests. Also, renames ifModifiedKey to cacheURL so that it now conveys the variable's nature rather than its purpose. -5 min/gzipped.
2012-11-29 17:16:42 +01:00
Matt Farmer
081c4efcf7
Alias options.method to options.type. Fixes #12004 .
2012-11-28 23:59:37 +01:00
Oleg
9ae6b1a019
Fix #12957 . Simplify wrapMap, it doesn't need end tags. Close gh-1044.
2012-11-27 21:32:59 -05:00
Richard Gibson
1052f9cb2b
save a byte
2012-11-27 09:53:30 -05:00
Richard Gibson
243d4cc83c
Don't let removeClass create attributes
2012-11-27 09:46:06 -05:00
Richard Gibson
0877d424e0
Fix #12959 : Optimize library-wide patterns
2012-11-27 01:59:22 +01:00
Corey Frang
516a7a8792
Fix #12803 . Add jQuery.fx.start as a hook point. Close gh-1024.
2012-11-25 15:23:02 -05:00
Scott González
84629a9b87
Fix #12869 . Zoom the body after support tests; avoids layout changes in IE8/9/10 in IE7 mode. Close gh-1025.
2012-11-25 15:16:16 -05:00
Dave Methvin
ae215fdcf8
Fix #12134 . Make .serialize() HTML5-compliant; provide a propHook for shimming.
2012-11-25 14:54:07 -05:00
Richard Gibson
a938d7b128
No ticket: compress ajax. Close gh-1041.
2012-11-25 13:07:46 -05:00
Dave Methvin
67df705bf5
Fix #12191 . jQuery.type should return "error" for Error objects.
2012-11-24 17:22:14 -05:00
dcooper
78c1560065
Fix #9960 , allow manipulation for parent document nodes. Close gh-924.
2012-11-24 16:53:27 -05:00
Dave Methvin
3fce794844
Fix #12733 . Ignore excess spaciness in event strings.
...
Thanks @bentruyman!
2012-11-24 16:05:20 -05:00
Dave Methvin
b7ec6ddd45
Fix #12868 . Use native focus/blur to get event order right.
2012-11-24 14:44:39 -05:00
Dave Methvin
1fb2f92c35
Fix #3827 . Get the correct checkbox status for a click handler.
2012-11-24 14:08:51 -05:00
Timo Tijhof
4fed8eb86d
Set async to true instead of async (prop vs. attr). Closes gh-1039
2012-11-21 21:47:59 -05:00
Richard Gibson
bb570fc373
Fix #12920 : remove addMandatoryAttributes. Close gh-1037.
2012-11-20 22:57:41 -05:00
Richard Gibson
22f58bd688
fix Safari test failures
2012-11-19 17:17:48 -05:00
Richard Gibson
e889134058
Fix #11795 , #10470 : keep scripts in DOM; execute only on first insertion. Close gh-864.
2012-11-19 09:50:19 -05:00
aFarkas
ca5e06a15c
Fix #12915 , add propHook for scrip src property on oldIE. Close gh-1035.
2012-11-18 21:20:12 -05:00
Dave Methvin
20be650bae
Merge branch 'x8908'
2012-11-18 14:56:46 -05:00
Elijah Manor
5904468b9c
Fix #8908 . Don't let change to originals affect clones in IE9/10. Close gh-886.
2012-11-18 14:49:36 -05:00
Richard Gibson
d08d48337f
update Sizzle
2012-11-16 15:57:43 -05:00
Dave Methvin
05fb5de3ee
Revert "Fixes #12569 . Improve Feature Detect For oldIE bubbling. closes gh-967"
...
This reverts commit 063ea024e9
.
I've beaten on this for a while and can't find a suitable feature detect that catches Chrome's support for focusin.
2012-11-14 21:09:12 -05:00
Dave Methvin
02c726f71c
Fix #12777 . Add applet to non-cacheable fragment types.
...
I don't want to add a unit test that creates a dependency on an applet.
2012-11-13 10:30:25 -05:00
Richard Gibson
e78cfb1a37
Fix #12858 : don't expose jQuery/Sizzle expandos
2012-11-09 23:43:46 -05:00
Corey Frang
877306738f
Unroll the ( || ) in the math - Fixes #12497 - Thanks @lukemella @curiousdannii - Closes gh-1019
2012-11-07 21:29:55 -06:00
Corey Frang
c45f6095f2
Keep track of a hiding state for toggle based animations - Fixes #8685
...
Closes gh-1018
2012-11-07 19:23:24 -06:00
Corey Frang
781a5c0b78
Ensure each tick gets it's own fxNow - Fixes #12837 - Thanks @chadparry
...
Closes gh-1022
Closes gh-1021
2012-11-07 19:22:14 -06:00
Dave Methvin
6b14cef7a8
Remove APIs now in jquery-compat
2012-11-07 20:12:03 -05:00
Richard Gibson
0ee9415902
Restore jQuery.access parameter mistakenly removed in 80d45a69
2012-11-06 09:53:00 -05:00
Richard Gibson
80d45a69ea
Fix #12840 : remove undocumented parameter "pass" from .attr. Close gh-1017.
2012-11-05 17:21:24 -05:00
Dave Methvin
68f001e709
Must attach the .selector to the new jQuery object.
2012-11-01 21:40:01 -04:00
Oleg
f651bf8893
Follow-up for .selector property removal
2012-11-01 21:31:55 -04:00
Dave Methvin
240b141a22
Fix #10299 . Add a propHook for oldIE link href.
2012-11-01 20:50:45 -04:00
Dave Methvin
9c2f000567
Remove unneeded parameter hockey in event shortcuts.
2012-11-01 19:48:21 -04:00
Dave Methvin
dc9913a0bf
Fix #12828 . Remove non-standard event properties.
2012-11-01 17:57:23 -04:00
Dave Methvin
395f1da76b
Fix #12827 . Remove exclusive event semantics from .trigger().
...
No unit tests were removed in the undoing of this feature. 😭
2012-11-01 16:56:35 -04:00
Dave Methvin
5ed0450dc4
Fix #12816 . Ensure .find() result are DOM ordered.
2012-10-31 22:43:04 -04:00
Dave Methvin
e8cf41a051
Fix #10544 . Remove deprecated .data() event namespaced triggering.
...
Data events were horribly slow, never documented, and caused strange interpretation of data items with dots in them.
2012-10-31 21:27:42 -04:00
Mike Sherov
e8f91514a6
Fix #12009 . $().find( DOMElement ) should pushStack properly. Close gh-927.
2012-10-30 13:32:53 -04:00
yiminghe
c78a3ba657
Fix #12685 . Handle inconsistent opacity for ie < 9. Close gh-1005.
2012-10-30 10:20:54 -04:00
Oleg
bea5ecbba7
Fix #10416 . Don't trust computed styles on detached elements. Close gh-941.
2012-10-28 23:32:54 -04:00
Timo Tijhof
36c9ecb0f5
Implement expectation test instead of using _removeData. Close gh-997.
...
* Removed inline usage of QUnit.reset() because it is messing with the
expectation model as reset does .empty() which does a recursive cleanData
on everything in #qunit-fixture, so any expectJqData above .reset() would
fail negatively.
Instead of calling reset inline, either updated the following assertions to
take previous assertions' state into account, or broke the test() up into
2 tests at the point where it would call QUnit.reset.
* After introducing the new memory leak discovery a whole bunch of tests were
failing as they didn't clean up everything. However I didn't (yet) add
QUnit.expectJqData calls all over the place because in most if not all of
these cases it is valid data storage. For example in test "data()", there
will be an internal data key for "parsedAttrs". This particular test isn't
intending to test for memory leaks, so therefor I made the new discovery
system only push failures when the test contains at least 1 call to
QUnit.expectJqData.
When not, we'll assume that whatever data is being stored is acceptable
because the relevant elements still exist in the DOM anyway (QUnit.reset
will remove the elements and clean up the data automatically).
I did add a "Always check jQuery.data" mode in the test suite that will
trigger it everywhere. Maybe one day we'll include a call to everywhere,
but for now I'm keeping the status quo: Only consider data left in storage
to be a problem if the test says so ("opt-in").
* Had to move #fx-tests inside the fixture because ".remove()" test would
otherwise remove stuff permanently and cause random other tests to fail
as "#hide div" would yield an empty collection.
(Why wasn't this in the fixture in the first place?)
As a result moving fx-tests into the fixture a whole bunch of tests failed
that relied on arbitrary stuff about the document-wide or fixture-wide
state (e.g. number of divs etc.). So I had to adjust various tests to
limit their sample data to not be so variable and unlimited...
* Moved out tests for expando cleanup into a separate test.
* Fixed implied global variable 'pass' in effects.js that was causing
"TypeError: boolean is not a function" in *UNRELATED* dimensions.js that
uses a global variable "pass = function () {};" ...
* Removed spurious calls to _removeData. The new test exposed various failures
e.g. where div[0] isn't being assigned any data anyway.
(queue.js and attributes.js toggleClass).
* Removed spurious clean up at the bottom of test() functions that are
already covered by the teardown (calling QUnit.reset or removeClass to
supposedly undo any changes).
* Documented the parentheses-less magic line in toggleClass. It appeared that
it would always keep the current class name if there was any (since the
assignment started with "this.className || ...".
Adding parentheses + spacing is 8 bytes (though only 1 in gzip apparently).
Only added the comment for now, though I prefer clarity with logical
operators, I'd rather not face the yayMinPD[1] in this test-related commit.
* Updated QUnit urlConfig to the new format (raw string is deprecated).
* Clean up odd htmlentities in test titles, QUnit escapes this.
(^\s+test\(.*)(>\;) → $1>
(^\s+test\(.*)(<\;) → $1<
[1] jQuery MinJsGz Release Police Department (do the same, download less)
2012-10-28 22:44:57 -04:00
Oleg
18e7a53d15
Elements created from html strings have a parentnode. Fixes #12392
2012-10-25 20:41:47 -04:00
Daniel Gálvez
b398a68333
Fix #11542 . document.body should not be special in .offset() and document.documentElement is the default element.offsetParent. Close gh-899.
2012-10-24 23:35:15 -04:00
Dave Methvin
69e2f068fe
Fix #9469 . Remove semi-functional .selector property. Close gh-1006.
...
Saved 65 bytes.
2012-10-24 22:36:20 -04:00
Rick Waldron
812c6087ad
Brute force property removal when removeData([a,b,c]). Fixes #12786
...
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2012-10-24 14:12:28 -04:00
Timmy Willison
2eff7fe72d
Sizzle: remove unneeded vars and POS regex (-22 bytes)
2012-10-24 10:35:08 -04:00
Mike Sherov
bede0123d9
new JSHINT mixed spaces/tabs is smart enough to not warn on multiline comments, rendering smarttabs useless
2012-10-22 13:29:43 -04:00
Matthias Jäggli
227c49a459
Fix #12411 , .removeClass(undefined) is a chaining no-op. Close gh-913.
...
.removeClass() //removes all classes, as documented
.removeClass(window.nonExistentVariable) // removes nothing
2012-10-21 21:06:41 -04:00
Oleg
9dd0b01017
Fix #12061 . Avoid window.onbeforeunload to permit multiple handlers. Close gh-894.
2012-10-20 22:29:18 -04:00
Dave Methvin
08341437e0
Remove deprecated $.uuid and dunseled $.deletedIds.
2012-10-20 22:18:29 -04:00
Marcel Greter
de9ff7cd17
Fix #12107 . Let .proxy() curry args without overwriting context. Close gh-866.
2012-10-20 22:10:06 -04:00
Oleg Gaidarenko
cafb542da9
Alternate fix for #11426 ; check responseText. Close gh-843.
2012-10-20 21:25:39 -04:00
Rick Waldron
8076a33bd8
Don't expose jQuery.deletedIds. Close gh-889.
2012-10-20 21:02:21 -04:00
Sai Wong
2b0e720406
Fix #12048 . Set attributes for XML fragments. Close gh-965.
2012-10-20 15:27:43 -04:00
Merrifield, Jay
408e5e08c2
Fixes #12518 , removes an offsetWidth on focus/blur events for an <IE9 bug that caused a performance hit. Closes gh-958
2012-10-20 14:00:30 -04:00
Sai Wong
5228f0a618
Fix #12610 , remove unneeded window.event. Close gh-968.
2012-10-20 10:07:01 -04:00
Richard Gibson
b5084b4bf2
Fix #4262 : faster .eq(), closes gh-1000.
2012-10-19 22:32:25 -04:00
Allen J Schmidt Jr
c6cf30a56e
Fix #12739 . Keep namespace when triggering with an Event. Close gh-972.
2012-10-19 16:42:13 -04:00
jaubourg
9346c0ef99
adds strict rule to jshint options (except for test files). "use strict" is added to the main jQuery closure and some "could-be-unsafe" this
trickery in effects is silenced.
2012-10-18 00:50:01 -04:00
James Huston
ee9687d441
Fix #12751 . Ensure parseJson throws in the same situations as JSON.parse. Close gh-993.
2012-10-17 16:28:55 -04:00
Richard Gibson
c31539c8a2
no ticket: fix jQuery suite failure on Android
2012-10-17 15:20:50 -04:00
Merrifield, Jay
063ea024e9
Fixes #12569 . Improve Feature Detect For oldIE bubbling. closes gh-967
2012-10-17 15:02:31 -04:00