Commit Graph

258 Commits

Author SHA1 Message Date
Rick Waldron
2f1ddd4507 Fix #11500. Allow triggered, simulated change events. 2012-04-10 21:54:07 -04:00
Dave Methvin
92a92be10f Fix #11049. Let bubbling submit be cancellable in oldIE. 2012-03-06 19:56:17 -05:00
Dave Methvin
633ca9c161 Fix #11076. If .clone() won't delegate, we must remediate.
Since `jQuery.event.add` can accept a handleObj there's no need to reiterate them as args, but we *do* need to set the `selector` variable correctly.
2012-01-28 16:30:35 -05:00
Dave Methvin
8d9025ca50 Fix #8165: Ignore events bubbling through disabled elements.
Although #6911 fixed the case where event.target was disabled, it missed the case where the target was a sub-element.
2012-01-19 22:14:24 -05:00
Rick Waldron
c0da49ff37 Fix #11130: Don't neglect the data arg when event-map is passed. 2012-01-12 20:30:45 -05:00
Richard Gibson
77de76b942 Fix #11145: Harden dispatch against a form-aliased "disabled" property 2012-01-11 21:56:18 -05:00
Dave Methvin
4534db196b Fix #11021. There should be no mangling of the "hover" namespace. 2011-12-13 22:29:35 -05:00
Dave Methvin
c584ce4f56 Fix #10984. Use origType when unbinding via the event object. 2011-12-13 21:40:59 -05:00
Dave Methvin
8cb065addc Fix #10844. Harden quickIs() against form-aliasing of the id property. 2011-11-21 11:33:21 -05:00
Dave Methvin
780c59b89d Fix #10791. SVG clamors for special treatment of its class names. 2011-11-16 10:35:53 -05:00
Dave Methvin
ca8fc725ac Allow mapped types to be removed by a namespace-only type name. 2011-11-15 11:38:55 -05:00
Dave Methvin
6736dd7168 Fix #10794. .triggerHandler() should not .preventDefault().
This also provides a resolution for #10699.
2011-11-15 10:23:24 -05:00
Dave Methvin
fa96f4bdee Pre-focus the element so the browser won't fire focus while we're faking it.
At this point the unit test is only testing our ability to fake-fire focusin the right way. These machinations are related to the problem in #6705.
2011-11-13 21:32:07 -05:00
Dave Methvin
d2815ed750 Disable DOM focusin test since it can't really work in the swarm. 2011-11-13 21:03:36 -05:00
Dave Methvin
683be093a6 Catch more cases where special events were incorrectly removed.
We can't take the blow-it-all-away shortcut because something in the middle of the list may be a mapped special event. On the bright side, -22!
2011-11-13 20:50:36 -05:00
Dave Methvin
774eba3388 Avoid collateral damage when removing bindType/delegateType special events. 2011-11-10 21:53:07 -05:00
Dave Methvin
5ba7f60822 Ensure the hover event doesn't match hovercraft. Witchcraft, maybe. 2011-11-10 18:05:58 -05:00
Dave Methvin
dd363d2c0f Fix #10705. Don't bail too soon in .off() event string processing. 2011-11-09 21:29:15 -05:00
Dave Methvin
39f9b846e7 Fix #10712. Deal with focus/blur morphing to focusin/focusout. 2011-11-08 23:08:04 -05:00
Dave Methvin
45101de696 Fix #10717, .trigger("load") on images can't bubble to window.
This means no manually triggered event named "load" can bubble, so avoid that name for delegated custom events.
2011-11-08 19:32:25 -05:00
Dave Methvin
90c907e8b6 Fix #10701, .preventDefault if an inline handler returns false.
Baby unicorns are slapped each time you use inline handlers, so do it sparingly.
2011-11-07 11:07:36 -05:00
Mike Sherov
f35ba5e699 Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit. 2011-11-06 15:27:42 -05:00
timmywil
38f087b5ae Add a way to fire native events using dispatchEvent/fireEvent in testinit.js; fixes failing click test in FF3.6 2011-10-28 14:17:14 -04:00
Dave Methvin
5c0c86378a DRY the hover pseudo-event, get the type right, allow override.
Now with working unit test for extra correctness! If external code defines a special.hover event, we won't string-hack "hover" into "mouseenter mouseleave".
2011-10-27 17:11:40 -04:00
Dave Methvin
df4a160be7 Pass correct arg list to special._default. Thanks @mikaelkaron! 2011-10-27 16:02:54 -04:00
Dave Methvin
746074f0f7 Remove attribute match from quickIs
As @timmywil points out, attributes and properties are confused by IE6/7. This commit also reworks the unit test case to do a better job of checking className matches.
2011-10-24 18:05:53 -04:00
Dave Methvin
ee3eb6cabf Fix #10567. Make sure quickIs matches correct class name. 2011-10-24 17:26:43 -04:00
Dave Methvin
84d2307e0e Fix #10563. Ensure event.currentTarget==this if delegated.
Now, event.delegateTarget is always the element where the event was handled, regardless of whether delegated handlers are attached.
2011-10-24 11:18:20 -04:00
Dave Methvin
4ac6f8d9d3 Make jQuery().off(event) work for delegated events.
Logic to handle detaching by event was in both .off() and jQuery.event.remove; now it's only in .off(). It's a bit of a strange case since the event object (not the jQuery set) specifies the element.
2011-10-24 11:18:18 -04:00
Dave Methvin
d28ab68699 Make event.currentTarget the delegate node, always.
This lets us use currentTarget for its intended use and avoids creating a non-standard delegateTarget property.
2011-10-24 11:18:14 -04:00
Dave Methvin
9fabe2028f Don't run direct handlers if delegate did .stopPropagation(). 2011-10-24 11:18:13 -04:00
Dave Methvin
0a3cab8d49 Fix #10489. Disconnected elements don't bubble to document. 2011-10-13 16:30:40 -04:00
Dave Methvin
92b06d302c Tweak live-blur() test to silence a IE8 swarm fail. 2011-10-11 22:55:10 -04:00
Dave Methvin
6afc2c074b Fixes #10477. Get .off(type, null, fn) right. 2011-10-11 20:31:45 -04:00
Dave Methvin
e5b16e3356 Rename jQuery.event.propHooks to .fixHooks.
We already have jQuery.propHooks for the .prop() method, so using the same name for unrelated functionality on a sub-namespace is crazy talk. Since the method involved is jQuery.event.fix(), this will hopefully tie them together. Oh, and it's shorter.
2011-10-05 21:41:32 -04:00
Dave Methvin
96a44a86d8 Fix #10375. Don't put type in jQuery.event.props
It's already set in jQuery.Event, and copying it can clobber values set by the caller, e.g., the UI widget factory.
2011-09-29 10:34:55 -04:00
Rick Waldron
51fd4593fc Restore original click prop hook 2011-09-26 13:03:24 -04:00
Rick Waldron
d11fcfac18 Fixed tests to run in IE9 2011-09-26 13:00:45 -04:00
Dave Methvin
c7838c3607 Minor cleanups to code. Futile effort to get IE to pass the unit test. 2011-09-25 22:04:52 -04:00
Dave Methvin
b4120a7430 propHooks now an object with props array and filter function.
Use the originalEvent to grab properties in filter functions since they often won't have been copied to event. Mark a few current props in the main jQuery.event.props list as deprecated, they aren't supported across all browsers.
2011-09-25 19:56:34 -04:00
Dave Methvin
ae27424b30 Merge branch '8789-fun-with-fix' of https://github.com/rwldrn/jquery into fix-8789-rwldrn-fix
Conflicts:
	src/event.js
	test/unit/event.js
2011-09-24 22:37:16 -04:00
Dave Methvin
03d95530b5 Remove the rarely-used pseudos from quickis.html
The cutting will continue until file size is improved.
2011-09-21 09:40:57 -04:00
Rick Waldron
92a80cbd05 Adds implementation tests for jQuery.event.propHooks #8789 2011-09-20 12:44:49 -04:00
Dave Methvin
63c9719330 Fix #9901, verified by this unit test. 2011-09-20 09:17:38 -04:00
Dave Methvin
9aa553aa18 Rework #1486 patch to avoid try/catch and look for hidden elements by .offsetWidth. Unit test currently disabled due to Chrome bug. 2011-09-19 15:42:31 -04:00
Dave Methvin
005958b731 Fixes for IE8. Avoid killer recursion in special events during removal. Use q instead of quote in unit tests. 2011-09-19 15:42:31 -04:00
Dave Methvin
6a670df9e9 Rework the special events interface to add handle and trigger hooks. Modify IE change/submit special events to take advantage of them. Rewrite mouseover/enter code as special events rather than inline code. In the event unit test, set a tabindex on the div element and focus it first to justify a legitimate blur event. 2011-09-19 15:42:31 -04:00
Dave Methvin
0dc7b16e94 Fixes #8858. Pass the .trigger(..., data) to the event.special._default method. 2011-09-19 15:42:31 -04:00
Dave Methvin
d74c6bd0f4 Add unit tests for quickIs cases and fix the regexp as a result. 2011-09-19 15:42:31 -04:00
Dave Methvin
f3a9d30812 Cleanup for on/off unit test. 2011-09-19 15:42:30 -04:00
Dave Methvin
5d6a1424aa jQuery 1.7 event work:
Add .on() and .off() methods.
Write existing methods in terms of on/off.
Rewrite delegated handling to remove "live" event.
Fix existing code for jQuery style guide.
Fix existing bug in unit tests calling .undelegate()
2011-09-19 15:42:30 -04:00
Dave Methvin
8b4bd89add Fix bad calls to .undelegate().
Remove two tests that assume "live" data structure.
2011-09-19 15:42:30 -04:00
Dave Methvin
81c778b2ca Fix #10208. Check for button as well as input when performing the #7071 VML crash workaround for IE special-events submit code. 2011-09-07 11:30:22 -04:00
Rick Waldron
b5f80a6e31 Removes empty, duplicate named test block. Fixes #9914 2011-07-26 11:49:23 -04:00
rwldrn
6926247bf4 Landing pull request 397. withinElement rewrite in event. Fixes #6234, #9357, #9447.
More Details:
 - https://github.com/jquery/jquery/pull/397
 - http://bugs.jquery.com/ticket/6234
 - http://bugs.jquery.com/ticket/9357
 - http://bugs.jquery.com/ticket/9447
2011-06-14 15:38:46 -04:00
Rick Waldron
c17f589ec9 Landing pull request 377. Check custom data != null(undefined), allows zero; Fixes #9285.
More Details:
 - https://github.com/jquery/jquery/pull/377
 - http://bugs.jquery.com/ticket/9285
2011-05-16 10:38:36 -04:00
Rick Waldron
ca367674c1 Restored /g flag to rspaces; Adds unit tests; Supplements #9008 2011-04-28 21:15:45 -04:00
Brian Brennan
3cb9c1835c Fix live mouseenter and mouseleave binding so they can be activated by triggers. Fixes #6514. 2011-04-17 18:17:31 -04:00
timmywil
ecf6a3c383 Switch QUnit div from depreceted #main to #qunit-fixture 2011-04-17 02:43:57 -04:00
John Resig
5d70c6d797 Add in unit tests for #6993. 2011-04-16 17:39:30 -07:00
timmywil
149a040794 Fix test suite fail in IE6/7 on event:undelegate - was failing an if where it shouldn't 2011-04-13 23:14:14 -04:00
Dave Methvin
f7f4ef91cf Merge branch 'fix_suite_fails' of https://github.com/timmywil/jquery into timmywil-fix_suite_fails 2011-04-12 19:42:35 -04:00
timmywil
69866fd2e5 VML.type test was causing multiple test suite fails, fix attributes.js fail in IE6 where the val(String/Number) tests were interfering with the val(Function) tests 2011-04-12 19:32:18 -04:00
Dave Methvin
bebd8bc01e Followup to #8753. Modify new Event constructor signature to jQuery.event(type, props), which can be exploited by jQuery.event.trigger as well. 2011-04-12 19:29:09 -04:00
John Firebaugh
0d8b247cab Accessing the 'type' property on VML elements fails on IE. Fixes #7071. 2011-04-12 16:48:22 -04:00
louisremi
f19a74f10b revert last commit 2011-04-12 13:12:58 +02:00
louisremi
01a2b51b26 switch double quotes with single quotes 2011-04-12 13:07:38 +02:00
louisremi
a5604aedb7 merge with master and resolve more conflicts 2011-04-12 11:29:25 +02:00
louisremi
f42010b657 third batch 2011-04-12 10:47:46 +02:00
jeresig
094c48e0c5 Merge branch '8777' of https://github.com/rwldrn/jquery into rwldrn-8777
Conflicts:
	src/event.js
2011-04-11 12:13:04 -04:00
jeresig
2c74ee46ee Merge branch 'eventprops.1.6final' of https://github.com/rwldrn/jquery into rwldrn-eventprops.1.6final
Conflicts:
	test/unit/event.js
2011-04-10 16:28:15 -04:00
Dave Methvin
98d83ef85f Fixes #8722. Remove try/catch used by #3533 to fix the IE Table Colon Blow bug, and instead check for colon in the event name. Thanks to daguej for scoping this out -- a colonoscopy you might say. 2011-04-07 22:52:15 -04:00
Dave Methvin
b7dd8404c5 Fixes #8712. Bubble custom events to the window when they are triggered. Ride that, Cowboy! 2011-04-06 22:11:58 -04:00
Dave Methvin
0fbadbcced Merge branch 'domready' of https://github.com/cowboy/jquery 2011-04-05 22:24:40 -04:00
Dave Methvin
c1316a4cb1 Shorten up the code and do event cleanup on test cases. 2011-04-05 21:59:09 -04:00
Dave Methvin
b5c7c507c1 Merge branch 'ticket_7883' of https://github.com/rwldrn/jquery into rwldrn-ticket_7883 2011-04-05 21:42:58 -04:00
rwldrn
4b0c26f0af Ticket #8777 undelegate by namespace 2011-04-05 18:55:07 -04:00
rwldrn
23a411b6bc Ticket #8753 Allow special properties to explicitly defined on jQuery.Event objects 2011-04-05 15:55:40 -04:00
Ben Alman
de0c25bef4 Updated DOM ready unit tests. 2011-03-31 13:36:16 -04:00
Ben Alman
368bfc0fe0 DOM Ready unit tests (but not the supporting fixed code). 2011-03-31 11:37:48 -04:00
Dave Methvin
459bd7f89d Followup commit for #7340 test case; make sure second test fires properly on IE by focusing to another element rather than blurring off the first. 2011-03-31 09:10:30 -04:00
jeresig
7705c35b14 Merge branch 'fix-8456-lost-mouseenter' of https://github.com/dmethvin/jquery into dmethvin-fix-8456-lost-mouseenter 2011-03-21 10:53:57 -04:00
Dave Methvin
2ac4067a63 Fixes #8456. Make sure parent is not null before crawling into its lap, so mouseenter is triggered on a mouseover event. 2011-03-09 22:38:26 -05:00
Dave Methvin
55ec6a71d2 Fixes #7340. Use a single capturing handler to simulate bubbling focusin/focusout event on non-IE browsers. Allow native DOM methods to fire events other than the currently active one back into jQuery. 2011-03-04 21:16:40 -05:00
Anton M
6b08d88d04 Fix some whitespace issues. 2011-02-15 22:09:09 +01:00
Dave Methvin
12c0e1a692 Fixes #7922. Copy the donor event when simulating a bubbling submit in IE so that we don't accidentally stop propagation on it. Remove a bunch of return statements that could also cancel the event. DRY out the liveFired change from #6359 by moving it to the trigger() function. 2011-02-15 22:08:39 +01:00
Anton M
8e40a84c24 Fix some unscoped tests which failed after recent changes to QUnit. 2011-02-15 21:03:34 +01:00
Anton M
78fc79fad4 Make sure .clone(true) correctly clones namespaced events. Fixes #4537. 2011-02-10 22:20:48 +01:00
Anton M
4490f4285c Fix some whitespace issues. Improve and correct an events test. 2011-02-10 22:20:47 +01:00
Colin Snover
7acb141ed7 Update $.data to use a function instead of an object when attaching to JS objects in order to hide attached metadata from JSON.stringify. Remove event.js code that was doing this before specifically for events, which is now redundant. Fixes #8108. 1.5-stable 2011-02-07 10:48:38 -06:00
jeresig
328a86f9a0 Revert "Make sure that focusin/focusout bubbles in non-IE browsers." This was causing problems with the focusin event, see: #7340.
This reverts commit 88068f82c1.

Conflicts:

	src/event.js
	test/unit/event.js
2011-01-21 09:24:09 -05:00
Colin Snover
e78d3a7e2d Merge in data_nocollide branch. Fixes #6968, improves unit testing framework checks for leaky stuff. 2011-01-17 15:31:43 -06:00
jeresig
987c44bee4 Merging pull request 183 for #7793. 2011-01-17 15:45:07 -05:00
Dave Methvin
007e2d152e Update test case to feature-detect Opera's lack of defaultPrevented and skip the test for it. 2011-01-15 10:24:13 -05:00
Colin Snover
e2941d5a98 Update unit tests with a leak detection mechanism for the various jQuery globals and fix all leaks in the tests. 2011-01-09 15:58:47 -06:00
Colin Snover
8e59a99e0a Change the way jQuery.data works so that there is no longer a chance of collision between user data and internal data. Fixes #6968. 2011-01-09 15:52:33 -06:00
rwldrn
612a908514 #7883 .delegate and .live should accept false as the fn arg, like bind 2011-01-01 13:49:59 -05:00
Colin Snover
3e0cc81504 Clean trailing whitespace from all files. 2010-12-30 00:34:48 -06:00
Dave Methvin
64ee5581af When a native browser event is bubbling up the DOM, make sure that the correct isDefaultPrevented value is reflected by jQuery's Event object. Fixes #7793. 2010-12-27 13:30:05 -06:00
Dave Methvin
b8931f7448 Test for standard createEvent before IE-specific click method.
Don't fallback to fake click; let's see which browsers fail, if any.
2010-12-27 12:43:48 -05:00