Timmy Willison
0fa52c11cb
Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755 .
2013-04-09 11:59:31 -04:00
Dave Methvin
85fc5878b3
Fix #13393 . Avoid IE9 activeElement of death.
2013-04-08 21:35:48 -04:00
Richard Gibson
a120bbbfae
Ref #12652 : Allow overriding native .click() suppression
...
(cherry picked from commit 14b09ef98e
)
2013-04-08 13:57:11 -04:00
Michał Gołębiowski
84a94acae1
delegate/undelegate changed to on/off in unit tests; refs #13554
2013-03-25 22:06:50 -04:00
Michał Gołębiowski
8ca9f931ec
bind/unbind changed to on/off in unit tests; refs #13554
2013-03-25 22:06:49 -04:00
Richard Gibson
3f05afbd8d
Ref #13353 , gh-1183: Capture onlyHandlers in jQuery.Event.isTrigger.
2013-02-28 16:59:12 -05:00
dmitrygusev
eee2eaf1d7
Fix typos. Close gh-1186.
2013-02-28 15:45:10 -05:00
Nguyen Phuc Lam
8bc7bdebef
Ref #13283 , move .andSelf() to deprecated.js. Close gh-1170.
2013-02-26 22:57:12 -05:00
Dave Methvin
2bbc3d5860
Fix #13471 . $().on(".xyz"...) should avoid later crash.
...
If the event type is an empty string we end up hanging in .off() which makes for
mighty hard debugging. Instead treat it as a no-op. Docs seem clear this is not
allowed.
2013-02-26 12:19:09 -05:00
Richard Gibson
59f5adb622
No ticket: Revise unit tests in anticipation of Sizzle-free builds
2013-02-22 20:13:36 -05:00
Richard Gibson
363299ac24
Ref #13316 : Sync all documents on full vs. minified source. Close gh-1147.
2013-02-07 15:16:28 -05:00
Rick Waldron
7f94a5cc3a
2.0: Rewrite data.js (Incl. event, manipulation, tests)
2013-02-03 15:27:55 -05:00
Andrew Plummer
d654914fd0
event: Stricter type checking in trigger - Fixes #13360 - Closes gh-1153
...
Squashed commit of the following:
commit 5935a362c7
Author: Andrew Plummer <plummer.andrew@gmail.com>
Date: Fri Feb 1 02:40:42 2013 +0900
Using "hasOwnProperty" to check for direct properties "type" and
"namespace" on events before triggering.
(cherry picked from commit f005af54e4
)
2013-01-31 12:04:32 -06:00
Dave Methvin
6f7b6915bf
Fix #12656 . Make event shorthands excludable.
2013-01-27 09:07:00 -05:00
Richard Gibson
348e1a75c8
de486684
with moar guard for IE6
...
(cherry picked from commit 6c29dd24e9
)
2013-01-13 23:00:14 -05:00
Richard Gibson
31b9579715
Fix #13203 : delegated events with selector matching Object.prototype property
2013-01-13 21:40:24 -05:00
Richard Gibson
de486684e3
Fix f860e0bd
Firefox failures
...
(cherry picked from commit 0a3a424e65
)
2013-01-13 20:37:53 -05:00
Richard Gibson
b75b9ef8d0
Fix #13180 : don't delegate into SVG <use>
...
(cherry picked from commits 36457cb6afc12d4a755cf93442a502783a669517..f860e0bd2f7dd228a14704d78ed5208cbe870d01)
2013-01-13 20:00:03 -05:00
Oleg
c8c6ab6924
Fix #12569 . Improve feature detect for event bubbling. Close gh-1076.
2012-12-20 22:08:32 -05:00
Dave Methvin
c928ed432a
Remove .live() tests now in Migrate plugin.
2012-12-18 14:42:37 -05:00
Timmy Willison
7d61c5238e
Adjust html parsing in event tests to use jQuery.parseHTML explicitly.
2012-12-13 15:52:59 -05:00
Oleg
93e18922c5
Fix #12956 . Improve cloneFixAttributes for IE9/10 case. Close gh-1034.
...
Remove clear(merge)Attributes hack
2012-12-11 22:06:26 -05:00
Timo Tijhof
55313d32a2
Test: Update index.html to new QUnit format. Close gh-1061.
...
Depends on jquery/sizzle#177 , included with the Sizzle submodule in this commit.
2012-12-10 21:48:20 -05:00
Dave Methvin
3fce794844
Fix #12733 . Ignore excess spaciness in event strings.
...
Thanks @bentruyman!
2012-11-24 16:05:20 -05:00
Dave Methvin
6b00b3cad9
Close #10882 . Test case for "hover" event in 1.9
2012-11-24 15:25:54 -05:00
Dave Methvin
b7ec6ddd45
Fix #12868 . Use native focus/blur to get event order right.
2012-11-24 14:44:39 -05:00
Dave Methvin
1fb2f92c35
Fix #3827 . Get the correct checkbox status for a click handler.
2012-11-24 14:08:51 -05:00
Richard Gibson
81b094b2c1
No ticket: update test suite to pass QUnit globals check in most environments. Close gh-1016.
2012-11-05 17:24:03 -05:00
Dave Methvin
d0015ecd2f
Missing semicolon.
2012-10-21 20:19:51 -04:00
Oleg
696c553053
Fix failing tests for beforeunload in Safari 5.0. Close gh-1002.
2012-10-21 20:14:05 -04:00
Oleg
9dd0b01017
Fix #12061 . Avoid window.onbeforeunload to permit multiple handlers. Close gh-894.
2012-10-20 22:29:18 -04:00
Allen J Schmidt Jr
c6cf30a56e
Fix #12739 . Keep namespace when triggering with an Event. Close gh-972.
2012-10-19 16:42:13 -04:00
Greg Lavallee
e83bc970f2
Fixes #12736 . Move hover event hack to deprecated.js for removal in 1.9. Closes gh-982.
...
Signed-off-by: Timmy Willison <timmywillisn@gmail.com>
2012-10-16 14:47:11 -04:00
Mike Sherov
ed9e34482a
enforce double quotes via JSHint. Closes gh-975
2012-10-16 10:17:14 -04:00
David Bonner
9104a3d5f2
Deprecate fn toggle Closes gh-970 https://github.com/jquery/2012-dev-summit/issues/24
2012-10-15 17:20:33 -04:00
James Huston
6ac8716789
Enforce expects in events.js ( https://github.com/jquery/2012-dev-summit/issues/53 ) Closes gh-961
2012-10-15 12:16:49 -04:00
Dave Methvin
84e45301c5
Update placeholder references to tickets.
2012-08-28 10:09:22 -04:00
Dave Methvin
afd717df9e
Fix #12383 . All selectors should be delegateTarget-relative
2012-08-28 10:07:16 -04:00
Mike Sherov
a9c2a9bf61
Scorch the earth and retreat on readyState interactive! Close gh-907.
2012-08-23 20:28:22 -04:00
Mike Sherov
0f553ed0ca
Fix #12282 . IE has premature .readyState == "interactive". Close gh-901.
2012-08-20 08:16:07 -04:00
Nikita Govorov
ff7b7cfd1d
Fix #12149 . Avoid memory leak on oldIE change events. Close gh-878.
2012-08-19 20:24:03 -04:00
Dave Methvin
1d8bf0a2b5
Fix #12203 . .undelegate() should not remove direcly bound events.
2012-08-07 20:49:34 -04:00
Timmy Willison
d8aa8e71b0
Sizzle: fix issue with adjusting the context on relative combinators in element-rooted qSA
2012-07-23 14:51:55 -04:00
Richard Gibson
e761e0c6e0
Support event delegation with relative selectors. Fixes #10762 . Closes gh-860.
2012-07-23 12:49:45 -04:00
Richard Gibson
60e249437c
Followup on #10791 : "[class~=foo]" is better. Closes gh-858.
2012-07-12 10:08:24 -04:00
Richard Gibson
d67c2fd863
Wontfix #10791 : please use "[class=foo]" with SVG elements
2012-07-11 17:17:47 -04:00
Mike Sherov
f5fd41252e
Fix #12018 , readyState "interactive" in oldIE lies! Closes gh-848.
2012-07-06 10:12:20 -04:00
Chad Killingsworth
de9bed319e
Make unit tests friendly to Closure Compiler. Closes gh-845.
...
Conflicts:
test/unit/effects.js
test/unit/offset.js
2012-07-05 15:52:42 -04:00
timmywil
b418fa1f09
UPDATE SIZZLE: completed rewrite for better things!
...
Remove reverse in traversing for comma selectors. Sizzle's handling of commas is now more consistent.
2012-07-02 11:34:26 -04:00
Dave Methvin
8a01c9201a
Fix #11382 . #11764 . Only prevent click events on disabled elements.
...
We don't want a disabled link/button to register delegated clicks, but we do want events like mouseover or custom events.
This is a compromise, there is no perfect solution. Well, the browsers could be consistent about direct vs. delegated events but *that's* not gonna happen.
2012-06-27 11:58:16 -04:00
Dave Methvin
94e744aec9
Fix #11315 . Selector for .on() is relative to delegateTarget.
...
This fixes a regresssion from 1.6.4. Be aware that nearly every place that this bug comes into play, the selector in use is incredibly inefficient.
2012-06-27 11:54:04 -04:00
Dave Methvin
4df3aaeab3
Add a semicolon in unit test; this pull predated lint mandate.
2012-06-22 16:21:09 -04:00
Timo Tijhof
9bb3494ce9
Fix #11925 , Pass eventHandle to special.teardown. Closes gh-831.
...
* Added unit test to confirm.
The third assertion fails without the fix in ./src/event.js
2012-06-22 15:57:46 -04:00
Rick Waldron
7ff3da186c
Unit tests are linted and passing.
2012-06-21 15:30:24 -04:00
timmywil
713cc86096
Move quickIs to Sizzle; Remove duplicate id matching in init; Added selector caching to Sizzle. Fixes #11826 .
2012-06-18 23:10:32 -04:00
Mike Sherov
5f35b3d9f9
Fix #11857 . Modularize css.js, add dependency management. Closes gh-816.
...
See the pull request for more info on the dependency management details.
2012-06-10 21:54:16 -04:00
Jason Moon
4757881759
Fix #11796 . Preserve oldIE change delegation on clone. Closes gh-789.
2012-05-22 21:29:13 -04:00
Dave Methvin
978acb9caf
Followup #11649 , clean up events in unit test.
2012-05-18 17:01:17 -04:00
Jason Moon
e93f2a89e2
Fix #11649 . Preserve oldIE submit flag when cloning, closes gh-772.
2012-05-18 16:34:30 -04:00
Dave Methvin
b6581df5de
Fix #11621 , $(document).trigger() must bubble to window.
2012-05-12 14:23:50 -04:00
jaubourg
e3cf0e220c
Transform $.bindReady into $.ready.promise. It is now possible to use $.ready.promise or $.when( $.ready ) to get the ready promise. Costs *1* byte min/gzipped. Unit test added.
2012-05-06 01:05:03 +02:00
Mike Sherov
f925c7a1c9
remove jQuery.quickReady, save bytes, style nits in tests
2012-05-04 10:17:30 -04:00
Mike Sherov
54fab3174c
Fix #10067 . Create jQuery.quickReady; closes gh-736.
...
Allows us to get to the ready state sooner by not waiting for iframes to load. If that causes backcompat pain, use `jQuery.quickReady = false` as prescribed by your developer.
2012-04-23 15:44:27 -04:00
Rick Waldron
8fadc5ba01
Make test async to please Opera 11.1; supplements #11500
2012-04-16 21:42:27 -04:00
Rick Waldron
2f1ddd4507
Fix #11500 . Allow triggered, simulated change events.
2012-04-10 21:54:07 -04:00
Dave Methvin
92a92be10f
Fix #11049 . Let bubbling submit be cancellable in oldIE.
2012-03-06 19:56:17 -05:00
Dave Methvin
633ca9c161
Fix #11076 . If .clone() won't delegate, we must remediate.
...
Since `jQuery.event.add` can accept a handleObj there's no need to reiterate them as args, but we *do* need to set the `selector` variable correctly.
2012-01-28 16:30:35 -05:00
Dave Methvin
8d9025ca50
Fix #8165 : Ignore events bubbling through disabled elements.
...
Although #6911 fixed the case where event.target was disabled, it missed the case where the target was a sub-element.
2012-01-19 22:14:24 -05:00
Rick Waldron
c0da49ff37
Fix #11130 : Don't neglect the data arg when event-map is passed.
2012-01-12 20:30:45 -05:00
Richard Gibson
77de76b942
Fix #11145 : Harden dispatch against a form-aliased "disabled" property
2012-01-11 21:56:18 -05:00
Dave Methvin
4534db196b
Fix #11021 . There should be no mangling of the "hover" namespace.
2011-12-13 22:29:35 -05:00
Dave Methvin
c584ce4f56
Fix #10984 . Use origType when unbinding via the event object.
2011-12-13 21:40:59 -05:00
Dave Methvin
8cb065addc
Fix #10844 . Harden quickIs() against form-aliasing of the id property.
2011-11-21 11:33:21 -05:00
Dave Methvin
780c59b89d
Fix #10791 . SVG clamors for special treatment of its class names.
2011-11-16 10:35:53 -05:00
Dave Methvin
ca8fc725ac
Allow mapped types to be removed by a namespace-only type name.
2011-11-15 11:38:55 -05:00
Dave Methvin
6736dd7168
Fix #10794 . .triggerHandler() should not .preventDefault().
...
This also provides a resolution for #10699 .
2011-11-15 10:23:24 -05:00
Dave Methvin
fa96f4bdee
Pre-focus the element so the browser won't fire focus while we're faking it.
...
At this point the unit test is only testing our ability to fake-fire focusin the right way. These machinations are related to the problem in #6705 .
2011-11-13 21:32:07 -05:00
Dave Methvin
d2815ed750
Disable DOM focusin test since it can't really work in the swarm.
2011-11-13 21:03:36 -05:00
Dave Methvin
683be093a6
Catch more cases where special events were incorrectly removed.
...
We can't take the blow-it-all-away shortcut because something in the middle of the list may be a mapped special event. On the bright side, -22!
2011-11-13 20:50:36 -05:00
Dave Methvin
774eba3388
Avoid collateral damage when removing bindType/delegateType special events.
2011-11-10 21:53:07 -05:00
Dave Methvin
5ba7f60822
Ensure the hover event doesn't match hovercraft. Witchcraft, maybe.
2011-11-10 18:05:58 -05:00
Dave Methvin
dd363d2c0f
Fix #10705 . Don't bail too soon in .off()
event string processing.
2011-11-09 21:29:15 -05:00
Dave Methvin
39f9b846e7
Fix #10712 . Deal with focus/blur morphing to focusin/focusout.
2011-11-08 23:08:04 -05:00
Dave Methvin
45101de696
Fix #10717 , .trigger("load") on images can't bubble to window.
...
This means no manually triggered event named "load" can bubble, so avoid that name for delegated custom events.
2011-11-08 19:32:25 -05:00
Dave Methvin
90c907e8b6
Fix #10701 , .preventDefault if an inline handler returns false.
...
Baby unicorns are slapped each time you use inline handlers, so do it sparingly.
2011-11-07 11:07:36 -05:00
Mike Sherov
f35ba5e699
Fix #10691 . Remove all instances of equals() and same(), as these are deprecated in QUnit.
2011-11-06 15:27:42 -05:00
timmywil
38f087b5ae
Add a way to fire native events using dispatchEvent/fireEvent in testinit.js; fixes failing click test in FF3.6
2011-10-28 14:17:14 -04:00
Dave Methvin
5c0c86378a
DRY the hover pseudo-event, get the type right, allow override.
...
Now with working unit test for extra correctness! If external code defines a special.hover event, we won't string-hack "hover" into "mouseenter mouseleave".
2011-10-27 17:11:40 -04:00
Dave Methvin
df4a160be7
Pass correct arg list to special._default. Thanks @mikaelkaron!
2011-10-27 16:02:54 -04:00
Dave Methvin
746074f0f7
Remove attribute match from quickIs
...
As @timmywil points out, attributes and properties are confused by IE6/7. This commit also reworks the unit test case to do a better job of checking className matches.
2011-10-24 18:05:53 -04:00
Dave Methvin
ee3eb6cabf
Fix #10567 . Make sure quickIs matches correct class name.
2011-10-24 17:26:43 -04:00
Dave Methvin
84d2307e0e
Fix #10563 . Ensure event.currentTarget==this if delegated.
...
Now, event.delegateTarget is always the element where the event was handled, regardless of whether delegated handlers are attached.
2011-10-24 11:18:20 -04:00
Dave Methvin
4ac6f8d9d3
Make jQuery().off(event) work for delegated events.
...
Logic to handle detaching by event was in both .off() and jQuery.event.remove; now it's only in .off(). It's a bit of a strange case since the event object (not the jQuery set) specifies the element.
2011-10-24 11:18:18 -04:00
Dave Methvin
d28ab68699
Make event.currentTarget the delegate node, always.
...
This lets us use currentTarget for its intended use and avoids creating a non-standard delegateTarget property.
2011-10-24 11:18:14 -04:00
Dave Methvin
9fabe2028f
Don't run direct handlers if delegate did .stopPropagation().
2011-10-24 11:18:13 -04:00
Dave Methvin
0a3cab8d49
Fix #10489 . Disconnected elements don't bubble to document.
2011-10-13 16:30:40 -04:00
Dave Methvin
92b06d302c
Tweak live-blur() test to silence a IE8 swarm fail.
2011-10-11 22:55:10 -04:00
Dave Methvin
6afc2c074b
Fixes #10477 . Get .off(type, null, fn)
right.
2011-10-11 20:31:45 -04:00
Dave Methvin
e5b16e3356
Rename jQuery.event.propHooks to .fixHooks.
...
We already have jQuery.propHooks for the .prop() method, so using the same name for unrelated functionality on a sub-namespace is crazy talk. Since the method involved is jQuery.event.fix(), this will hopefully tie them together. Oh, and it's shorter.
2011-10-05 21:41:32 -04:00
Dave Methvin
96a44a86d8
Fix #10375 . Don't put type
in jQuery.event.props
...
It's already set in jQuery.Event, and copying it can clobber values set by the caller, e.g., the UI widget factory.
2011-09-29 10:34:55 -04:00