Commit Graph

201 Commits

Author SHA1 Message Date
Oleg Gaidarenko
14eba98c8f Build: code style fixes after all those reverts 2015-12-22 18:51:04 +03:00
Oleg Gaidarenko
b87e93bdc9 Revert "Attributes: do not set properties to false when removing booleans"
This reverts commit 5c086c3782.
2015-12-22 14:16:55 +03:00
Timmy Willison
689270e9d8 Attributes: remove flakey test for selected attribute
- The change is already covered by the "checked" test.
  Since this test is redundant, just drop it.

(cherry picked from commit 87bd130289)
2015-10-26 16:08:59 -04:00
Timmy Willison
5c086c3782 Attributes: do not set properties to false when removing booleans
Fixes gh-1759

(cherry picked from commit 47ccf3daad)

Conflicts:
	src/attributes/attr.js
2015-10-26 16:08:49 -04:00
Richard Gibson
a93d1d7d78 Tests: Post-Summit cleanup
Ref 67d7a2eefe
Ref c752a5030b

(cherry picked from commit f931786018)
2015-10-25 15:33:31 -04:00
Joelle Fleurantin
cf4092eeea Attributes: fix tabIndex on <img> in IE11
Fixes gh-2647
Closes gh-2664

(cherry picked from commit c752a5030b)

Conflicts:
	src/attributes/prop.js
2015-10-25 15:15:55 -04:00
Dave Methvin
c003cd6bc8 Attributes: Use simpler boolean check vs a function call
Ref gh-2491

(cherry picked from commit 4bf1a09522)
2015-10-25 15:00:51 -04:00
Dave Methvin
f24726daa3 Attributes: Remove undocumented .toggleClass( boolean ) signature
Fixes gh-2491
Close gh-2618

(cherry picked from commit 53f798cf4d)

Conflicts:
	src/attributes/classes.js
2015-10-25 15:00:48 -04:00
Oleg Gaidarenko
2f0cedc997 Tests: further improvements QUnit 2.0 migration
* Remove QUnit jshint globals
* Extend QUnit.assert methods
* Use assert.async instead of start/stop/done

Ref b930d14ce6
Ref c8d15a2f9f
2015-09-08 04:15:54 +03:00
Oleg Gaidarenko
4543815eed Tests: Partially use new qunit interface
http://qunitjs.com/upgrade-guide-2.x/

For most of the boring work was used
https://github.com/apsdehal/qunit-migrate package

However, it can't update local qunit helpers, plus in some places
old QUnit.asyncTest signature is still used

Ref b930d14ce6
Fixes gh-2540
2015-09-07 20:14:59 +03:00
Oleg Gaidarenko
20ddbe4f59 Build: Update jscs and lint files
Ref 10fdad742a
Fixes gh-2056
2015-09-07 20:14:50 +03:00
Oleg Gaidarenko
b8b111e337 Tests: don't use deprecated argument in test declaration
Ref aabe94edb4
2015-07-30 20:48:26 +03:00
Oleg Gaidarenko
57fb2dc02e Attributes: don't test SVG CSS-class manipulation in IE8
Ref 20aaed367f
2015-05-19 13:47:11 +03:00
Timmy Willison
b5b0d72774 Attributes: add SVG class manipulation
- Note: support for SVG is limited in jQuery,
  but this is one area where the cost vs benefit ratio
  was acceptable.

Fixes gh-2199
Close gh-2268
2015-05-12 10:24:42 -04:00
Timmy Willison
7bce5b0ee1 Attributes: revert returning null for non-existant attributes
Ref https://github.com/jquery/jquery/issues/2118
2015-03-30 15:30:21 -04:00
Timmy Willison
a403655491 Attributes: revert returning null for non-elements 2015-03-16 14:12:00 -04:00
Timmy Willison
17bd6e9cf9 Attributes: fix failing test for new return value 2015-03-16 11:54:43 -04:00
Winston Howes
afca031826 Attributes: return null when attribute does not exist
Fixes gh-2118
Close gh-2129

Conflicts:
	test/unit/attributes.js
2015-03-16 11:54:33 -04:00
Michał Gołębiowski
aec41a5c41 Attributes: Simplify the option val hook; backport a test from master
The hook is still defined; not using it could cause issues in IE<11.
Backport the test from the master branch.

Also, IE10 no longer throws when value not set but it still doesn't trim the
value. IE11 has all those issues fixed; support comments are updated.

(cherry-picked from f6302b0b53)

Fixes gh-1902
Closes gh-1901
2014-12-08 22:51:55 +01:00
Michał Gołębiowski
90d7cc1d8b Misc: Drop support for older browsers; update support comments
That includes IE<8, Opera 12.x, Firefox<29, Safari<6.0 and some hacks
for old Blackberry.

Fixes gh-1836
Fixes gh-1701
Refs gh-1815
Refs gh-1820
2014-12-08 21:12:33 +01:00
Richard Gibson
f6f8848fbe Tests: Minor updates for QUnit 1.16 compatibility
More to come later.
2014-12-05 12:32:49 -05:00
Oleg Gaidarenko
9cdaa75b86 Tests: Correct logic of a broken assertion 2014-04-15 17:46:25 +04:00
John Hoven
9ec429cf62 Attributes: Trim whitespace from option text when returned as a value
Fixes #14858
Ref #14686
Closes gh-1531
2014-03-20 15:44:09 -04:00
Oleg
2b98a2636b Tests: Fix code style issues
(cherry-picked from a2250b0f4c)
2014-01-16 07:05:11 +04:00
Oleg
f601dd4d23 Attrs: Restore ability to pass array to jQuery#val
Thanks @gibson042
2014-01-16 06:55:56 +04:00
Oleg
92cbf5362c Attrs: Fix valHook for option element
Fixes #14686
2014-01-16 03:21:25 +04:00
cjqed
305eefe6ab Tests: Avoid use of QUnit.reset() in tests by splitting them
Closes gh-1470
Ref #1457
2014-01-03 08:01:46 +04:00
Michał Gołębiowski
4743f017a6 Add tests for class manipulation on jQuery object containing more than one element. Close gh-1404. (cherry-picked from 35b2b94979) 2013-10-25 00:50:55 +02:00
Richard Gibson
6a6604b785 No ticket: Hide the testing-support jQuery from tests
(cherry picked from commit 0c18520923)

Conflicts:

	test/data/testrunner.js
2013-09-03 11:13:20 -04:00
Timmy Willison
05d907d1b1 Fix for custom attr handles duck-punching the boolean attr handle 2013-08-28 12:12:37 -04:00
Richard Gibson
a7f42d9966 Fix #13835: classes separated by form feed
(cherry picked from commit d8a35011ec)
2013-05-13 21:55:18 -04:00
Timmy Willison
d2435ead36 Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755.
Conflicts:
	src/.jshintrc
	src/data.js
	test/unit/attributes.js
	test/unit/core.js
	test/unit/data.js
	test/unit/event.js
	test/unit/manipulation.js
	test/unit/queue.js
	test/unit/traversing.js
	test/unit/wrap.js
2013-04-09 12:21:54 -04:00
Oleg Gaidarenko
08e57b1de7 Adjust the return value of the tabIndex propHook to match the spec. Fixes #13752. 2013-04-08 21:41:08 -04:00
Michał Gołębiowski
4adde5d145 Update grunt-contrib-jshint to 0.3.0, ref gh-1204. 2013-04-03 20:41:41 -04:00
ruado1987
48d71d0c3e Fix #13514: Set selectedIndex to -1 when non-matching value is set on a select. Close gh-1191. 2013-03-22 12:46:13 -04:00
dmitrygusev
a13cadadf6 Fix typos. Close gh-1186. 2013-02-28 15:55:55 -05:00
Richard Gibson
1f76536650 No ticket: Revise unit tests in anticipation of Sizzle-free builds
(cherry picked from commit 59f5adb622)
2013-02-22 20:33:00 -05:00
Dave Methvin
24e7624554 Fix #12656. Make event shorthands excludable. 2013-01-27 00:35:42 -05:00
Mike Sherov
abead1c86b Fixes #13088: under IE8, $(selector).attr('style') always return lowercase string 2012-12-31 12:30:02 -05:00
Richard Gibson
06f46dad93 let .attr(checked|selected, true) update the property 2012-12-16 10:39:19 -05:00
Richard Gibson
a763ae7277 Fix #11115: Normalize boolean attributes/properties. Close gh-1066. 2012-12-15 23:16:48 -05:00
Richard Gibson
2c40fdd4a8 Fix #12600: don't use value property in place of value attribute. Close gh-1063. 2012-12-14 10:37:20 -05:00
Oleg
13651f296d Fix #9646. Cloned nodes shouldn't affect original in IE7. Close gh-947. 2012-12-13 09:29:40 -05:00
Dave Methvin
40e08f81bd Missed a var declaration in aad235b325. 2012-12-11 23:35:51 -05:00
Dave Methvin
aad235b325 Fix #13011. Let 'type' attribute be set if the browser allows. 2012-12-11 23:16:08 -05:00
Timo Tijhof
55313d32a2 Test: Update index.html to new QUnit format. Close gh-1061.
Depends on jquery/sizzle#177, included with the Sizzle submodule in this commit.
2012-12-10 21:48:20 -05:00
Oleg
9ae6b1a019 Fix #12957. Simplify wrapMap, it doesn't need end tags. Close gh-1044. 2012-11-27 21:32:59 -05:00
Richard Gibson
243d4cc83c Don't let removeClass create attributes 2012-11-27 09:46:06 -05:00
aFarkas
ca5e06a15c Fix #12915, add propHook for scrip src property on oldIE. Close gh-1035. 2012-11-18 21:20:12 -05:00
Richard Gibson
48bd8b509b No ticket: speedup effects tests 2012-11-12 21:06:16 -05:00